Giter Site home page Giter Site logo

Comments (6)

toddmotto avatar toddmotto commented on May 22, 2024

Just use one IIFE, then all functions are in the same scope.

from angularjs-styleguide.

MattKetmo avatar MattKetmo commented on May 22, 2024

Indeed, that'd what you recommend in your README 😄

In fact I though about @johnpapa's styleguide where each file is wrapped with an IIFE.

I was more confident about collisions in the case you use variables out of the (main) function scope:

(function() {

var foo = 'bar';
function FooController() {
  this.foo = foo;
}
angular
  .module('app')
  .controller('FooController', FooController);

})();

but finally I don't think this is a good practice (mostly for testing purpose)

from angularjs-styleguide.

toddmotto avatar toddmotto commented on May 22, 2024

Each file for me is an overkill, there isn't really need to and it gets a bit repetitive unless automated. Variables would be part of presentational logic if anything, therefore quite unique - just like the CSS we write, none of it should conflict with other parts of the app :)

If you've got 1000 JavaScript files, 999 extra function calls isn't necessary either!

from angularjs-styleguide.

fredbliss avatar fredbliss commented on May 22, 2024

Agreed with @toddmotto - I don't believe in bloating code with safeguards that would be avoidable using overhead-free best practices. A good variable naming convention could accomplish the same, in my opinion.

from angularjs-styleguide.

johnpapa avatar johnpapa commented on May 22, 2024

automation makes this easy to remove if you need to. and if this is the biggest problem your app has, then you are in great shape. :)

If you run locally in non automated mode (which a lot of devs do) the IIFE's give you a a truer sense of the global isolation than if you just avoid them.

I use a template/snippet, and there are no slowdowns.

Again, this is not a big deal as long as you do protect yourself in some way

from angularjs-styleguide.

MattKetmo avatar MattKetmo commented on May 22, 2024

Ok, interesting point of view. Indeed, it's not a big deal, and there is not a single way to manage scripts compilation.

Thanks for your answers

from angularjs-styleguide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.