Giter Site home page Giter Site logo

Comments (19)

tog22 avatar tog22 commented on August 22, 2024

@cdc482 given the above do you think you should make this your top priority?

from eahub.

cdc482 avatar cdc482 commented on August 22, 2024

I'm happy to make this my priority. To be clear, this should be my first
priority followed by the hiltons task suggester, right?

On Wednesday, July 8, 2015, tog22 [email protected] wrote:

@cdc482 https://github.com/cdc482 given the above do you think you
should make this your top priority?


Reply to this email directly or view it on GitHub
#11 (comment).

from eahub.

tog22 avatar tog22 commented on August 22, 2024

Yes

from eahub.

cdc482 avatar cdc482 commented on August 22, 2024

I agree with your suggestion about using a drupal hook in template.php. Definitely seems like the easiest solution. I am considering a couple other options:

  1. Adding a your profile/signout button to replace the sign up/login button in the search area block. (Visible to authenticated users etc.)
  2. Using token's in the path for the Your Profile menu button (easier said than done of course).

Anyway, it'd be nice to get some feedback if anyone has a couple minutes as to which of these are worth pursuing. Also, I've run into a problem modifying php files. For some reason, the changes are not reflected on the site, and I'm sure it's not an issue with cache. I'm sure I'll figure it out eventually, but I just thought I'd ask in case anyone has experienced this before.

from eahub.

tog22 avatar tog22 commented on August 22, 2024

(Note for others: I helped Chris sort out the cache issue, you need
to click clear caches on
http://diffdocroot.effectivealtruismhub.com/admin/config/development/performance
when that happens.)

I receive a lot of email and limit my time spent on it, so may take a while
to see or reply to messages; I may be able to reply more quickly to emails
with an indication of timeframes (e.g. with 'urgent' in the subject line).

Contact information: http://bit.ly/tagoogleplus

On 10 July 2015 at 13:40, cdc482 [email protected] wrote:

I agree with your suggestion about using a drupal hook in template.php.
Definitely seems like the easiest solution. I am considering a couple other
options:

  1. Adding a your profile/signout button to replace the sign up/login
    button in the search area block. (Visible to authenticated users etc.)
  2. Using token's in the path for the Your Profile menu button (easier
    said than done of course).

Anyway, it'd be nice to get some feedback if anyone has a couple minutes
as to which of these are worth pursuing. Also, I've run into a problem
modifying php files. For some reason, the changes are not reflected on the
site, and I'm sure it's not an issue with cache. I'm sure I'll figure it
out eventually, but I just thought I'd ask in case anyone has experienced
this before.


Reply to this email directly or view it on GitHub
#11 (comment).

from eahub.

tog22 avatar tog22 commented on August 22, 2024

which php files have you changed chris?

On 11 July 2015 at 11:29, Tom Ash [email protected] wrote:

(Note for others: I helped Chris sort out the cache issue, you need
to click clear caches on
http://diffdocroot.effectivealtruismhub.com/admin/config/development/performance
when that happens.)

I receive a lot of email and limit my time spent on it, so may take a
while to see or reply to messages; I may be able to reply more quickly to
emails with an indication of timeframes (e.g. with 'urgent' in the subject
line).

Contact information: http://bit.ly/tagoogleplus

On 10 July 2015 at 13:40, cdc482 [email protected] wrote:

I agree with your suggestion about using a drupal hook in template.php.
Definitely seems like the easiest solution. I am considering a couple other
options:

  1. Adding a your profile/signout button to replace the sign up/login
    button in the search area block. (Visible to authenticated users etc.)
  2. Using token's in the path for the Your Profile menu button (easier
    said than done of course).

Anyway, it'd be nice to get some feedback if anyone has a couple minutes
as to which of these are worth pursuing. Also, I've run into a problem
modifying php files. For some reason, the changes are not reflected on the
site, and I'm sure it's not an issue with cache. I'm sure I'll figure it
out eventually, but I just thought I'd ask in case anyone has experienced
this before.


Reply to this email directly or view it on GitHub
#11 (comment).

from eahub.

tog22 avatar tog22 commented on August 22, 2024

Option 1 is good thinking! That sounds so much quicker and easier that I'd
think it's worth doing for now and moving onto other priorities if you
agree. I imagine it should get just as many clicks and profile creations as
the old 'Your Profile' menu link would? Feel free to suggest tweaks to the
wording if you think it'd help with that.

On 11 July 2015 at 11:29, Tom Ash [email protected] wrote:

which php files have you changed chris?

On 11 July 2015 at 11:29, Tom Ash [email protected] wrote:

(Note for others: I helped Chris sort out the cache issue, you need
to click clear caches on
http://diffdocroot.effectivealtruismhub.com/admin/config/development/performance
when that happens.)

I receive a lot of email and limit my time spent on it, so may take a
while to see or reply to messages; I may be able to reply more quickly to
emails with an indication of timeframes (e.g. with 'urgent' in the subject
line).

Contact information: http://bit.ly/tagoogleplus

On 10 July 2015 at 13:40, cdc482 [email protected] wrote:

I agree with your suggestion about using a drupal hook in template.php.
Definitely seems like the easiest solution. I am considering a couple other
options:

  1. Adding a your profile/signout button to replace the sign up/login
    button in the search area block. (Visible to authenticated users etc.)
  2. Using token's in the path for the Your Profile menu button
    (easier said than done of course).

Anyway, it'd be nice to get some feedback if anyone has a couple minutes
as to which of these are worth pursuing. Also, I've run into a problem
modifying php files. For some reason, the changes are not reflected on the
site, and I'm sure it's not an issue with cache. I'm sure I'll figure it
out eventually, but I just thought I'd ask in case anyone has experienced
this before.


Reply to this email directly or view it on GitHub
#11 (comment).

from eahub.

cdc482 avatar cdc482 commented on August 22, 2024

Glad you like option 1. Makes sense to me as well. I'll add a sign out button to the your profile page, and work on this option for now.

from eahub.

tog22 avatar tog22 commented on August 22, 2024

👍

from eahub.

tog22 avatar tog22 commented on August 22, 2024

Looks good, just theme it to look exactly like 'LOG IN OR SIGN UP'. Nice initiative adding 'sign out', you'd need to make that link to /user/logout.

from eahub.

tog22 avatar tog22 commented on August 22, 2024

@haryshwaran may be interested in taking this on if you can't do so soon @cdc482 - he may ask you for pointers!

from eahub.

tog22 avatar tog22 commented on August 22, 2024

@haryshwaran just added 'LOG OUT'. All that's needed to complete this issue is now to add a link alongside it to 'YOUR PROFILE' which points to the user's unique URL (e.g. /user/1 or /user/tom-ash ) rather than /user. @cdc482 may be able to explain his progress on this - I think it involved using Drupal tokens. If not I'd recommend googling those @haryshwaran .

from eahub.

haryshwaran avatar haryshwaran commented on August 22, 2024

For I have added a "MY PROFILE" button and linked it to /user so that there is something available right now for users to click on and view their profile. Will look into drupal tokens and resolve this.

from eahub.

tog22 avatar tog22 commented on August 22, 2024

Ah, that would absolutely be a good idea, but unfortunately we have reason not to want it (briefly, because it'll lead people to share the wrong URL for their EA Profiles in a new EA Forum feature coming up). We actually had a link to /user before but took it down for this reason. Thanks for what would otherwise have been a totally sensible initiative, but could you reverse it if you've put it on prod?

from eahub.

haryshwaran avatar haryshwaran commented on August 22, 2024

Ah, I see.. Got it, removed it. Will see how to about it using drupal tokens

from eahub.

haryshwaran avatar haryshwaran commented on August 22, 2024

Link added via custom module. To do ( low priority ) will be to make the links themeable with drupal themes.

from eahub.

tog22 avatar tog22 commented on August 22, 2024

@haryshwaran low priority, but can you make 'my profile' say 'your profile' and split LOG IN OR SIGN UP into 2 links, to /user/login & /user/register . your choice how to style this.

from eahub.

haryshwaran avatar haryshwaran commented on August 22, 2024

We will be changing the theme very soon in any case, we could club the changes along with the theme change. Could we close this issue?

from eahub.

tog22 avatar tog22 commented on August 22, 2024

We may as well leave it open as we'd want it in whatever theme we use. 😄

from eahub.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.