Comments (3)
Thanks for the report. Those types are marked doc(hidden)
and are not considered public API.
async-stream/async-stream/src/lib.rs
Lines 164 to 166 in ac3fa6b
Is it possible to reproduce this using only the public API?
from async-stream.
Thanks for the response! I agree that these being doc(hidden)
communicates that they are not intended to be part of the public API, and that actually trying to write code invoking them myself would constitute "abuse" rather than "use" -- apologies that the original issue title came across more strongly than intended.
I don't know of a way to produce this UB using only the doc-visible public API. I'm not able to find any reference for how unsafe
conventions interact with doc(hidden)
, but my perspective as someone who would potentially review code using this crate is that, in the context of a code review, I don't expect to have to check whether we're referencing a doc(hidden)
symbol in order to audit for potential UB (even if, as a reviewer, I would be very reluctant to let someone use
a module path that included __private
...). To me, marking these functions as unsafe
is more in the spirit of how unsafe
serves to highlight contracts you have to avoid violating in order to avoid UB -- please correct me if I'm off-base here, though!
from async-stream.
Addressed by #84.
from async-stream.
Related Issues (20)
- Dependency on tokio_test is missing in the crate HOT 1
- Filter example HOT 1
- Re-land #53
- async_stream_impl 0.3.1 removes stream, try_stream, breaking async_stream =0.3.0 HOT 1
- Can't use ? if try_stream! wraps select! HOT 3
- try_stream is !Send with ? and MutexGuard or try-block HOT 2
- Cannot use "yield" and "?" on the same line
- Rustfmt cannot format stream! blocks HOT 2
- Experiment with a proc-macro-free API HOT 2
- `#![no_std]` compatibility
- `try_stream!` / `stream!` with error close stream HOT 3
- Sorry, wrong repo .-.
- Break / Return / Exit early HOT 2
- Feature request: yield*
- Return a stream conditionally HOT 1
- `let` - `else` expressions don't work with try stream HOT 2
- Please issue a new release
- Example for an empty stream for stubbing HOT 2
- Change Macros to Support Rust Analyzer Autocomplete HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from async-stream.