Giter Site home page Giter Site logo

Comments (10)

Darksonn avatar Darksonn commented on August 14, 2024

Adding a new target requires changes to both Tokio and mio. The changelog entry you saw added the changes needed in Tokio, but the changes in mio have still not happened, so it's not really supported yet.

from tokio.

coolbluewater avatar coolbluewater commented on August 14, 2024

Can we please keep this open until fixed?

from tokio.

coolbluewater avatar coolbluewater commented on August 14, 2024

@Darksonn wrote

Adding a new target requires changes to both Tokio and mio. The changelog entry you saw added the changes needed in Tokio, but the changes in mio have still not happened, so it's not really supported yet.

Also, what changelog entries are you referring to? I'm simply reporting that tokio does not build for this target.

from tokio.

Darksonn avatar Darksonn commented on August 14, 2024

We close issues when the relevant changes are merged, not when a release containing them is released.

from tokio.

Darksonn avatar Darksonn commented on August 14, 2024

The fix in Tokio happened in #6465.

from tokio.

coolbluewater avatar coolbluewater commented on August 14, 2024

@Darksonn, the build of a fresh clone of the master branch is still broken so I don't understand what you mean.

from tokio.

coolbluewater avatar coolbluewater commented on August 14, 2024

Your responses make no sense. Please read this issue again.

from tokio.

Darksonn avatar Darksonn commented on August 14, 2024

A fresh clone of Tokio's master branch will use a released version of mio, and not the latest master branch of mio.

from tokio.

coolbluewater avatar coolbluewater commented on August 14, 2024

I get that. What I don't understand is you saying that "The fix in tokio happened in #6465".

That was not sufficient to make the build actually work. tokio needs to update to the version of mio that has the fix.
I opened another issue in mio and they replied with the version that has the fix.

This issue means that tokio does not build for vision os. Period. Fixing it means making the build actually work, not some small part of the work.

Your replies are obtuse and unhelpful, and not to the point.

from tokio.

Darksonn avatar Darksonn commented on August 14, 2024

No, Tokio does not need to update to that mio version because Tokio depends on a range of mio versions. We are not pinned to a specific release. Once mio makes a v0.8.x release containing VisionOS support, it will work with Tokio as-is. No further changes are needed in the Tokio repository.

from tokio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.