Giter Site home page Giter Site logo

is config read only? about amon HOT 2 OPEN

tokuhirom avatar tokuhirom commented on June 13, 2024
is config read only?

from amon.

Comments (2)

nihen avatar nihen commented on June 13, 2024

twitterで@tokuhirom さんとやりとりしたので許可をとりコピペしました!。
(@tokurhiom さんは protected)


tokuhirom: チバさんからきてる issueをみて、すごくごもっともなんだけど、どうやってなおしたらいいのかさっぱりおもいつかない

nihen: configは読み取り専用なので、もし今書き込める実装になってたとしてもそのときの動きは保証しません!でいい気はします。その方針にしたが、Flavorのコードを修正するだけで。

tokurhiom: 書き込み自体はできていいモノなんですよねえ。

nihen: あらま。そうするとポイントはクラスの違うAmon2インスタンス間でconfigは共有されるべきかどうかってとこですね。

tokurhiom: 共有されてもされなくてもいいけど、コストはかからないようにしたい、というかんじですね

nihen: なるほどー。共有される可能性があるのでそれに依存した使い方はやめましょーという感じですかね。

tokuhirom: そうっすねー


というわけで、Flavorだけ治す方向で。のちほどpull reqします。

from amon.

markstos avatar markstos commented on June 13, 2024

I'm not catching everything here through the translation, but if this a discussion about whether "config" should be read-only or not, my preference would be that it has been read-only.

That policy has worked where for the Config plugins I've developed for CGI::Application. It gives the developer of a complex project the assurance that the config variable that they see in the code has the same value that they see in the config file.

from amon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.