cprop cannot handle setting nils

[tolitius]

cprop cannot handle setting nils

[tolitius]

the reason for str->value to front the Clojure reader is because not all configuration and properties come from edn like in your table above. Some of them, quite often, come from ENV, system properties or configuration managers (e.g. Consul).

In those cases types are not as clear. For example, let's look at overriding a "username":

=> (require '[cprop.core :as cp])
=> (cp/load-config)
{:datomic ...
 :source
 {:account
  {:rabbit
   {...
    :username "guest"}}}

=> (System/setProperty "source_account_rabbit_username" "0x42")

with the way code is written now:

=> (cp/load-config)
{:datomic ...
 :source
 {:account
  {:rabbit
   {...
    :username "0x42"}}}

relying on Clojure reader (i.e. removing "these lines"):

=> (cp/load-config)
{:datomic ...
 :source
 {:account
  {:rabbit
   {...
     :username 66}}}

I added better comments and a test so it clarifies things a bit

[bn-darindouglass-zz]

Thanks for the quick turn-around!

Yeah there’s definitely some overlap where things can be parsed oddly; though I think the times where the reader would mis-parse something would be the vast minority situations.

Anyway, my original intent was lost among my thoughts on the use of the reader: you cannot nil a setting, it’ll be set to “nil” instead. A simple (= “nil” v) before the alpha number regex should fix the use case.