Comments (5)
Yeah, this is more of a code clarity thing than a real issue - and could be changed without any change to the behaviour the user sees.
My concern is that requests to /api/pml
do too much atm - and will probably lead to mess in app.js. There are a bunch of interactions to account for.
e.g. if the pml is fine, but there is some asclepius error - what should the status code be? We probably still want to present the drugs found to the user, but show some error in the ddi panel.
Chaining a request to /api/pml
then /api/ddis
would allow the errors etc to be handled separately
from pathways.
Think we should ask him what the desired behaviour is here before we make changes. Doesn't seem particularly hard to change anyway
from pathways.
I think that at the very least, if we keep the system as is, the pml controller is very badly named as it deals with much more than just pml
from pathways.
Sounds like a good solution to me. I have a lot to do with my FYP today so if I get round to this, it won't be until this evening.
from pathways.
see #102 - there will now probably be a middle step. Turning english drugs from /api/pml
into dinto uris for /api/ddis
from pathways.
Related Issues (20)
- Report PML construct name-clash HOT 9
- PML-TX Save PML to File HOT 5
- Release 1 Feedback HOT 1
- Specify a Delay HOT 5
- Identify Parallel DDIs HOT 2
- Identify Sequential DDIs HOT 2
- Mock DDI Characterisation Data
- Real DDI Mock Good-Bad Time Generator
- Real DDI Agonist-Antagonist Mock Time Generator
- Locked down versions for e2e compose
- Release 2 UI HOT 3
- improve Parser/Lexer errors
- app.js refactor HOT 1
- Tabbed UI HOT 1
- DDI line numbers
- Tab UI testing docs overhaul
- `Save PML File` documentation
- Remove warnings
- Final UI discussion HOT 1
- Final doc check
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pathways.