Giter Site home page Giter Site logo

Comments (5)

c-brenn avatar c-brenn commented on June 6, 2024 1

Yeah, this is more of a code clarity thing than a real issue - and could be changed without any change to the behaviour the user sees.

My concern is that requests to /api/pml do too much atm - and will probably lead to mess in app.js. There are a bunch of interactions to account for.

e.g. if the pml is fine, but there is some asclepius error - what should the status code be? We probably still want to present the drugs found to the user, but show some error in the ddi panel.

Chaining a request to /api/pml then /api/ddis would allow the errors etc to be handled separately

from pathways.

laurmurclar avatar laurmurclar commented on June 6, 2024

Think we should ask him what the desired behaviour is here before we make changes. Doesn't seem particularly hard to change anyway

from pathways.

22a avatar 22a commented on June 6, 2024

I think that at the very least, if we keep the system as is, the pml controller is very badly named as it deals with much more than just pml

from pathways.

laurmurclar avatar laurmurclar commented on June 6, 2024

Sounds like a good solution to me. I have a lot to do with my FYP today so if I get round to this, it won't be until this evening.

from pathways.

c-brenn avatar c-brenn commented on June 6, 2024

see #102 - there will now probably be a middle step. Turning english drugs from /api/pml into dinto uris for /api/ddis

from pathways.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.