Giter Site home page Giter Site logo

Comments (3)

tomasstolker avatar tomasstolker commented on August 17, 2024

Hi Jens,

Thanks for opening this issue! Currently it is indeed not the desired behavior of those routines. I had some discussion about this recently with Rico, but we hadn't found the time yet to implement this and deprecate obs_nodding_irregular.

The obs_nodding recipe from EsoRex can only do a pair-wise subtraction if I am not mistaken. Since we want indeed to maintain the individual integrations, we were thinking that we should first collapse several integrations to build up the background image that will be subtracted, in order to limit the noise in the individual nod-subtracted images? So e.g. collapse 6 to 10 and subtract this mean image from 1 to 5.

from pycrires.

Hoeijmakers avatar Hoeijmakers commented on August 17, 2024

I agree that merging frames is probably the best, most generic way to deal with this. That may be a bit easier said than done, if all those frames need to be individually pipeline reduced before being co-added. The most logical place where this should ultimately be addressed is probably the cr2res_obs_nodding pipeline recipe itself.

For now I have created a PR with a temporary fix based on obs_nodding_irregular, adding an optional keyword to pair A's and B's one to one in sequence.

from pycrires.

tomasstolker avatar tomasstolker commented on August 17, 2024

That's true, although util_calib can be used with calib_type='nodding' for calibrating the science frames. The output could then be collapsed by subsets and used for the pair-wise subtraction with obs_nodding. But this may not be something that can be quickly implemented indeed.

Thanks a lot for creating the PR with a temporary fix! That seem indeed a good solution 👍.

from pycrires.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.