Comments (3)
I agree @tomastrajan even in my own finding I found out the same. Using only required modules in the feature module would eventually reduce my bundle size but there would be trade off.
I have used same technique of using a shared module in my unit tests. Importing shared modules in tests is making them slow. I will try to removing less used Material modules from the shared module and check the results.
I think we can closed this issue
from angular-ngrx-material-starter.
@Zaky7 all the best with your projects, cheers !
from angular-ngrx-material-starter.
Hi @Zaky7!
Using of SharedModule
represents a tradeoff between most optimized bundle size and developer experience (convenience).
It is true that we would get smallest possible bundles by listing every single used module in every lazy feature module.
On the other hand maintaining these lists is pretty tedious and error prone ( its easy to forget to remove import of module when the component is no longer used in the lazy feature) and also when testing, importing everything one by one in test bed is EXTRA tedious.
Hope this answers your question. Both approaches can work, it's up to you what you chose to optimize and what is your main requirement.
from angular-ngrx-material-starter.
Related Issues (20)
- Is there any reason why services are exported in CoreModule HOT 4
- Enable strict mode HOT 5
- How to handle async localstorage to sync with ngrx
- cypress is still listed as a feature, although support is removed
- Help please ! HOT 6
- DatePipe & DecimalPipe HOT 1
- Problem using translation in a separate module HOT 3
- Toolbar Covering Top of Scroll HOT 2
- Manual selection of theme HOT 1
- i18n editor HOT 1
- link leads to 404 github page. README.md file HOT 1
- Storing password in state HOT 1
- By using pnpm package manager it has an error:
- Add Arabic translation
- fix Hebrew typos and improve Hebrew translations in a few places
- BrowserModule has already been loaded error when importing an angular library that imports BrowserModule HOT 1
- selector issue HOT 5
- Debugging. HOT 2
- current demo pages not accessible directly. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-ngrx-material-starter.