Comments (6)
Reading https://consul.io/docs/commands/leave.html & https://consul.io/docs/agent/basics.html I see 2 different ways of shutting it down, but with the same outcome: The node leaves the cluster.
The only disadvantage I see by using consul leave
is that it won't work if someone puts the RPC agent on a different port than the default, which then means that consul leave
would require the different port, while killproc
won't. Any specific reason why you (@pdilung ) went with consul leave
? If not then I would propose to stay with killproc
to avoid any problems when putting the RPC agent on a different port.
The other question is if we really wanna wait 60s by default or maybe just 10? I have no idea what a reasonable timeout might be, but 60s sounds quite long.
Otherwise it looks fine to me, though I think the problem might be different or non-existent on EL7, as systemd might take care of it.
from consul-rpm.
@duritong:
ad. consul leave
vs killproc
: I am fine with killproc
and can reimplement this.
ad. MAXWAIT
: This is configurable in /etc/sysconfig/consul
, however, I have no objection using 10s as a sane default. I tried to run it in a while loop with 10s and it works just fine.
Let me know and I can push the changes you propose into pdilung:fix-rh6-init-script branch.
ad. RHEL7 & systemd: Let's try it in our lab :)
from consul-rpm.
Souns fine, let's update the branch then.
from consul-rpm.
OK, done. I tested it and it seems to work fine.
from consul-rpm.
thanks a lot, I merged the PR, if you find any problems on EL7 let's open another ticket.
from consul-rpm.
OK, let's do so then
from consul-rpm.
Related Issues (17)
- Cloudflare redirects HOT 3
- Suggestion: Provide a logrotate file HOT 2
- Log to syslog on EL6 HOT 1
- Consul not starting HOT 5
- No License HOT 5
- init script for consul-template is broken HOT 4
- COPR repo is not updated to the latest version HOT 1
- add /etc/consul-template/ for backwards compatibility HOT 1
- Duplicate unpack prompt breaks build HOT 2
- Update for current releases HOT 3
- Restrict executable permission HOT 3
- consul.init has the port hardcoded in the Startup
- Repository path missing or not specified.
- no web-ui rpm built
- SELinux policy HOT 1
- consul .rpm for centos 7 missing 'net-tools' dependency
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from consul-rpm.