Wait should be implemented in start/stop functions in RHEL6 init script

[tomhillable]

Wait should be implemented in start/stop functions in RHEL6 init script

[duritong]

Reading https://consul.io/docs/commands/leave.html & https://consul.io/docs/agent/basics.html I see 2 different ways of shutting it down, but with the same outcome: The node leaves the cluster.

The only disadvantage I see by using consul leave is that it won't work if someone puts the RPC agent on a different port than the default, which then means that consul leave would require the different port, while killproc won't. Any specific reason why you (@pdilung ) went with consul leave? If not then I would propose to stay with killproc to avoid any problems when putting the RPC agent on a different port.

The other question is if we really wanna wait 60s by default or maybe just 10? I have no idea what a reasonable timeout might be, but 60s sounds quite long.

Otherwise it looks fine to me, though I think the problem might be different or non-existent on EL7, as systemd might take care of it.

[pdilung]

@duritong:
ad. consul leave vs killproc: I am fine with killproc and can reimplement this.
ad. MAXWAIT: This is configurable in /etc/sysconfig/consul, however, I have no objection using 10s as a sane default. I tried to run it in a while loop with 10s and it works just fine.
Let me know and I can push the changes you propose into pdilung:fix-rh6-init-script branch.
ad. RHEL7 & systemd: Let's try it in our lab :)

[duritong]

Souns fine, let's update the branch then.

[pdilung]

OK, done. I tested it and it seems to work fine.

[duritong]

thanks a lot, I merged the PR, if you find any problems on EL7 let's open another ticket.

[pdilung]

OK, let's do so then