PHP 7.4 deprecated notice when inserting values using an array as the data source

<a class="user-mention notranslate" data-hovercard-type="user" data-hover

<div class="snippet-clipboard-content notranslate position-relative overflow-auto" data-snippet-clip

PHP 7.4 PHP Deprecated: implode(): Passing glue string after array is deprecated. Swap the parameters in vendor/tommyknocker/pdo-database-class/PDODb.php on line 435 about pdo-database-class HOT 6 CLOSED

tommyknocker commented on July 20, 2024

PHP 7.4 PHP Deprecated: implode(): Passing glue string after array is deprecated. Swap the parameters in vendor/tommyknocker/pdo-database-class/PDODb.php on line 435

from pdo-database-class.

Comments (6)

bas-surlinio commented on July 20, 2024

Replace this line with:
if (isset($dataColumns[0])) $this->query .= ' ('.implode(', ',$dataColumns).') ';

from pdo-database-class.

Phenomite commented on July 20, 2024

@bas-surlinio

Replace this line with:
if (isset($dataColumns[0])) $this->query .= ' ('.implode(', ',$dataColumns).') ';

As in this?

L435:

if (isset($dataColumns[0])) $this->query .= ' (`\'.implode(\'`, `\'$dataColumns).\'`) ';

from pdo-database-class.

bas-surlinio commented on July 20, 2024

Correct

from pdo-database-class.

borakayalar commented on July 20, 2024

        //if (isset($dataColumns[0])) $this->query .= ' (`'.implode($dataColumns, '`, `').'`) ';
        if (isset($dataColumns[0])) $this->query .= ' (`' . implode('`, `', $dataColumns) . '`) ';

from pdo-database-class.