Comments (4)
I'm no expert on this topic either, but the above did work for me (both for releases and dialyzer), so I could open a PR and add this to the relevant section.
If I may add my two cents on the breaking changes: I believe there is a trend in the ecosystem where more and more libraries move to the 'you need to add it to the supervisor tree yourself' approach. One example of this is goth
: https://github.com/peburrows/goth#upgrading-from-goth--13 (a popular google auth library). So you might want to reconsider making this the default way forward for this library, especially if there might be some problems with not putting it in the supervisor tree yourself. Of course you could release it as 2.0
to indicate the breaking change.
from fun_with_flags.
In addition I also had to add the following to make dialyzer work:
dialyzer: [
plt_add_apps: [:fun_with_flags],
]
from fun_with_flags.
Hey there, thank you for using the package and for reporting the issue.
I must admit that I'm not very familiar with how this setup would interact with releases. I haven't used them a lot, personally.
If there is a way to make this better, either with code changes or with better documentation, we should! Do you have any suggestion in mind? My only request is to avoid breaking changes.
from fun_with_flags.
I believe that this has been resolved in the last couple of released versions, because of the changes in how config is handled.
from fun_with_flags.
Related Issues (20)
- (UndefinedFunctionError) function Ecto.Query.from/2 is undefined or private HOT 1
- Can't change config without doing a `mix deps.clean fun_with_flags`. HOT 3
- Changing `ecto_table_name` config requires recompile HOT 4
- Setting cache `enabled: false` crashes the app HOT 1
- [Question] Ensuring feature flags are in sync across dev environments HOT 3
- Proposed Postgrex Changes HOT 6
- The module `FunWithFlags.Supervisor` was given as a child to a supervisor but it does not exist HOT 11
- Support redis sentinel HOT 1
- Switch on ecto integration only if Ecto.Adapters.SQL exists HOT 5
- Warnings when FWF is used with ecto HOT 2
- Don't require compile-time configuration HOT 1
- Use case: flag <-> group relationship HOT 5
- mix release issue using Elixir 1.15.0 HOT 2
- Next release and Elixir 1.15 support HOT 2
- `disable/2` returns {:ok, true} HOT 1
- Suggest disabling cache for tests HOT 2
- low priority feature req - automatically remove stale flags HOT 1
- Feature request: Add timestamp columns HOT 1
- Asymmetry between options accepted by `enable`/`disable` compared to `enabled?/2` HOT 5
- Avoid Thundering Herd on Rollout of new Release HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fun_with_flags.