Comments (7)
Work is in progress... :)
from fsrepo.
I tried to get it running and checked out the fsrepo-2.0 branch; the changes in the liferay classes seem not too hard to adapt to, but you seem to plan to heavy refactor the classes in the fsrepo package, because you commented out nearly the whole FSRepo class...? :)
from fsrepo.
Uh, Yes.
I'm refactoring almost whole codebase because I'm not very proud of the code. And to be able to support different versions (6.1 CE+EE, 6.2 CE+EE) I need to make it cleaner. I want to separate out permissions from the code itself and structure the code better to enable the support for the different portal versions.
It's possible to adapt 1.x code to 6.2, most of the new API is related to check in/out + locks which FSRepo doesn't support anyway. It's perhaps currently the easiest way to get 6.2 covered. Feel free to send me a pull request if you manage to do it.
Thanks!
from fsrepo.
Sorry for the delay - I was ill for a week.
I have a working version here deployed on 6.2 GA2. I am not experienced with git/github - what do I have to do for a pull request?
I stashed back all the changes, rebased to master, merged the stashed changes back and created a branch out of it, made the local commit. What's next? I can't push the branch, obviously I lack access right for that. Do I have to do it with github's web interface?
from fsrepo.
I see.
For pull requests you need to fork the repository into your account.
Once it's forked you are able to clone it to your local computer.
Then you create a branch based on master, apply your changes and push the branch to origin (GH).
Once it's uploaded to GH, you go to GH, select the branch and click on "Pull Request" where you can add some notes. That's basically it.
Or, you could save the commit into file and send it by mail to me :)
from fsrepo.
I always want to learn new things, but it's really not easy for a git beginner. ;)
Well, I made the pull request, I hope I did it correct now. If not please let me know and i send those five files. :)
from fsrepo.
Thanks @McAviti!!!!
I merged it into master and did some modifications, mostly source formatting.
I try to test it first and then make it public. But feel free to use it, I'll let you know if there are any changes.
Thanks again!
from fsrepo.
Related Issues (14)
- Permissions in FSRepo HOT 5
- Folder/Subfolder creation throws exception HOT 7
- File Check-In and Check-Out HOT 3
- Inherited permissions checking for files inside folders HOT 1
- Consider migration to dl-repository-shared layer HOT 6
- Packet for query is too large HOT 3
- Installation of the web archive HOT 1
- Moving a folder from FSRepo til Liferay doc. lib. HOT 1
- Media Gallery Image Icons and Preview only work for .png and .jpeg (v1.1) HOT 1
- NPE in picture preview HOT 10
- Moved content stay in src HOT 2
- Clicking on download file throws error HOT 4
- Multiple file uploads support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fsrepo.