Crashes with later versions of JSDOM

[toranb]

Crashes with later versions of JSDOM

[toranb]

Honestly I've avoided jsdom since mid/late 2013 after a few upgrades gone wrong. If you would be willing to help I'd prefer to upgrade this to vanilla jasmine (or QUnit/Mocha)

[testtubemamoth]

Hi - I'm having exactly the same problem.
Perhaps you could specify the required jsdom version in your dependencies? Would be super helpful :)

Thanks!

[toranb]

So what if you add a dependency to this (does the npm install do what you are doing manually anyway?)

"dependencies": {
"ember-template-compiler": "1.5.0"
"jsdom": " ??"
},

[cotman]

Hi Toran,

Just got notified on this from the last reply.

Honestly I've avoided jsdom since mid/late 2013 after a few upgrades gone wrong. If you would be willing to help I'd prefer to upgrade this to vanilla jasmine (or QUnit/Mocha)

Wish I could - I'm afraid I know very little Javascript, but do make good use of your precompiler as a user of DEP for deployments ;-) .

So what if you add a dependency to this (does the npm install do what you are doing manually anyway?)
"dependencies": {
"ember-template-compiler": "1.5.0"
"jsdom": " ??"
},

Yeah, that would work - a default npm install of DEP will currently pull in the later jsdoms and won't work. However, if you specified "jsdom": "0.11.1" in your package.json then it would continue to work out of the box for most folk doing a straight npm install.

Thanks.

[toranb]

I clearly did not read this well enough the first time around - my fault. Thanks for raising this issue - I've added the jsdom version you mentioned and updated the compiler to 1.6.1 (the most current version)

Let me know if you have any other issues!