Comments (4)
Lua errors are more consistent, and easier to maintain. Since they provide a stack-trace, it's fairly easy to diagnose them.
from cunn.
I feel like in practice the caller of pointwiseApply simply reports an error with CUTORCH_DIM_WARNING, so maybe pointwiseApply actually has more information on what went wrong. Ideally we'd combine the two, but I guess we don't have a good mechanism for that.
So I'd also be in favour of Lua errors.
from cunn.
Ah, actually from what I recall when writing it the intent was that the API shouldn't depend upon running in a Lua interpreter, but that battle (having a tensor manipulation API that could be used outside of a Lua environment) was lost in Torch a long time ago.
The only specific information that the caller has is the arguments passed to the function, and what index they were. But it's quite ambiguous when there are 2+ arguments, the DIM_WARNING error doesn't say anything at all about size mismatch, and returning more error status to indicate exactly what argument it didn't like and why it didn't like it is just as fragile as the current situation.
I think I'll just add the Lua error throwing in the pointwiseApply* functions for specific failure cases, and remove the retval checking in cutorch itself.
from cunn.
I suppose you can use THError to not be Lua-specific.
from cunn.
Related Issues (20)
- CPU and GPU gave different results HOT 1
- use memory of GPU for a process HOT 3
- Jetson Tx2 compile error HOT 3
- wrong number of arguments for function call with ClassNLLCriterion HOT 5
- Utilizing multiple gpus with different memory to full use
- PReLU tests from test.lua give error
- CUDA fails after installation HOT 1
- Model faster in GeForce GTX 1060 6 GB compared to Google cloud K80 12 GB, missing something?
- THREAD PANIC and Segmentation fault when passing data parallelized model between threads
- Strange issue with DataParallelTable on 1080 Ti HOT 1
- How to implement own c/cuda module in cunn and nn?
- Inconsistence in SpatialMaxPooling and SpatialMaxUnpooling operations for torch.CudaTensor that leads to an error
- error: identifier "WARP_SHFL_XOR" is undefined
- Bug: spatialdepthwiseconvolution has memory leak problem HOT 2
- How to resume training from a certain epoch or how to update an already trained model in torch ?
- /torch/install/share/lua/5.1/cunn/THCUNN.lua:119: table index is nil issue HOT 1
- Fails to build against CUDA9 HOT 1
- CMake Error at THCUNN_generated_LookupTable.cu.o.cmake:267 (message):
- I got this to compile on Ubuntu 20.04 HOT 1
- Problems while Compiling with CUDA11, Ubuntu 20.04 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cunn.