Allow multiple classes for `no_toc_section_class`

[toshimaru]

Allow multiple classes for `no_toc_section_class`

[XhmikosR]

Friendly ping @toshimaru :)

I could replace those headers with a header > 5 but ideally this should be fixed.

[toshimaru]

@XhmikosR Hi, I checked your site and I found you configured custom class for no_toc_section.

https://github.com/twbs/bootstrap/blob/9788baedeadddba9d0bcd4dbaea43d65ece9bcbd/_config.yml#L65

You have two options.

1. Use bd-example class instead of no_toc_section.
2. Remove your no_toc_section_class configuration, and use no_toc_section.

I think it's not a bug, so I close the issue, but if any further issue, please let me know.

[XhmikosR]

@toshimaru How come you think it's not a bug? I already add the no_toc_section in the callout, so I expect any header there to not show up in ToC.

[toshimaru]

• Use bd-example class instead of no_toc_section.
• Remove your no_toc_section_class configuration, and use no_toc_section.

I'd say I already gave options to fix a issue. I'm a not English speaker so if you can't understand the options I gave, could you explain why it doesn't make sense? I could explain the detail more. 👍

[XhmikosR]

1. I can't add bd-example, that's for other uses
2. Since I can't specify multiple classes there, I'm stuck.

[XhmikosR]

OK, maybe I misunderstood the docs. I will try something else and if it works then the docs need to be clarified.

[toshimaru]

I got it, you'd like to configure multiple no_toc_section classes!! (In your case, no_toc_section and bd-example). Currently, you can configure only one no_toc_section_class.

So, I'd like to propose another option:

• Remove your no_toc_section_class configuration, which means you can use only no_toc_section class. Then, add no_toc_section to the existing bd-example element.

For exmaple:

<div class="bd-example">

Change it to:

<div class="bd-example no_toc_section">

[XhmikosR]

Yeah but that's the problem, we have 133 bd-example instances. Hence why I had suggested from the beginning to allow multiple classes there :)

[toshimaru]

Hmm, I originally don't want to allow no_toc_section_class to have multiple values because it might cause the performance decrement, but I've understood your use case.

I change this issue title and re-open it.

[XhmikosR]

I'm not very familiar with Ruby, but it shouldn't have a noticeable performance penalty in theory.

Let me know if you make a beta with this feature.

Thanks!

[toshimaru]

Yes, you’re probably right, I’m being too sensitive about the performance.

I could implement this without the performance impact, am going to release it in the next version. :)

[toshimaru]

@XhmikosR Allowing multiple no_toc_section classes has been released at v0.9.1.

ref. https://github.com/toshimaru/jekyll-toc#skip-toc-section