CoreDNS ConfigMap patch - upstream keyword in EKS with CoreDNS 1.7.0

[lescactus]

CoreDNS ConfigMap patch - upstream keyword in EKS with CoreDNS 1.7.0

[renatomjr]

Same here. This makes it impossible to use the Traefik Mesh in eks

[0rax]

I think I just found the issue which was "introduced" by previous PR #774 when I added support for build version with suffixes. It seems like goversion considers v1.7.0-eksbuild.1 as a pre-release version of v1.7.0 while it is not.

versionCoreDNS17 := goversion.Must(goversion.NewVersion("v1.7"))
coreDNSVersion := goversion.Must(goversion.NewVersion("v1.7.0-eksbuild.1"))
fmt.Println(coreDNSVersion.LessThan(versionCoreDNS17)) // Prints true

I will submit a patch to make sure this is fixed while I am looking at adding support for CoreDNS 1.8.

---

EDIT: It seems like there is two solutions:

• Either compare the current CoreDNS version with the last version to support the upstream keyword:

coreDNSVersion := goversion.Must(goversion.NewVersion("v1.7.0-eksbuild.1"))
coreDNSVersion.LessThanOrEqualTo(goversion.Must(goversion.NewVersion("1.6.9"))

• Or strip the pre-release part of the version using version.Core() which would require an update to the go-version package:

coreDNSVersion := goversion.Must(goversion.NewVersion("v1.7.0-eksbuild.1"))
coreDNSVersion.Core().LessThan(goversion.Must(goversion.NewVersion("1.7"))

This issue seems to be something to consider more broadly during the version check in prepare as it might consider v1.8.0-eksbuild.0 as a pre-release and satisfy the LessThan check for the build version.

[kevinpollet]

Closed by #790