Giter Site home page Giter Site logo

Comments (14)

skl avatar skl commented on August 25, 2024

@kou1okada you are referring to the header comments block in the code? That has never been altered and the LICENSE file does still state MIT. The original Google Code project is in fact still GPL v2 however I do not have control of that as I am only a committer. I'm happy to licence the header comments block as per the LICENSE file that Stephen Jungels created, however the Google Project will still state GPL v2 unless Stephen changes it.

from apt-cyg.

kou1okada avatar kou1okada commented on August 25, 2024

Hmm,,,
But ο½”he header comments block in this repository was already altered from the GPLv2 to the MIT license by Stephen Jungels, when he republished here the apt-cyg.
Actually, the trunk line of this repository was clean from GPLv2, before you imported codes from the original repository on the Google Code.
As long as the header comments block has the GPLv2 term, LICENSE.txt file will not produce any effect.
We must patch to descendants of fc54d5c, if we want to keep this repository under the MIT license.
Because anyone, exclude Stephen Jungels, can not remove again the GPLv2 term from there.

Thanks.

from apt-cyg.

 avatar commented on August 25, 2024

I understand your concern about the licensing, but if thats the case even the first commit is suspect, see

e8891b5

How are we supposed to resolve that? Rebase the whole repo?

from apt-cyg.

kou1okada avatar kou1okada commented on August 25, 2024

Sorry, I couldn't understand the meaning about "first commit".
e8891b5 was brought by Stephen Lang from r12 of the original repository on Google Code at 2014-02-20. It was not exist on this repository before 2014-02-20. acabffd seems the initial commit, but it is not the initial commit of this repository.
The initial commit of this repository is ab235c0 that was committed by Stephen Jungels at 2013-07-29.

The points of this license problem is below:

  • Stephen Jungels created this repository under the MIT license.
  • Stephen Lang reintroduced the GPLv2 term to the head of ./apt-cyg.
  • Nobody can remove it.

I'm sorry, that I have no idea to solve this problem without doing git reset --hard to fc54d5c for master.
Fortunately, the critical patch merged to the current master (that re-introduced the GPLv2) is only fc54d5c...46fb5d3. It provides multi-architecture support and .xz package support.
But fc54d5c...3d67e12 is better solution to provide these supports, I think.
Unfortunately, some patches will be revoked by above solution, but it have only minimal impact on the function of apt-cyg.

apt-cyg_repository

Thanks.

from apt-cyg.

 avatar commented on August 25, 2024

This should now be fixed. I ran these commands

git reset --hard 46fb5d3
git merge -X ours origin~21
git cherry master origin | awk '$0=$2' |
  git cherry-pick --stdin --keep-redundant-commits -X theirs

It ended up regressing the README somewhat, but that can be easily fixed. Let me
know if the result is okay. I have a backup pre force push if it comes to that.

from apt-cyg.

skl avatar skl commented on August 25, 2024

I was originally trying to keep both the Google Code SVN project and this Git project in sync using git svn, that may help explain has this all came about in the first place. As to that is still possible going forward - I'm unsure as the repos are to be licensed differently. What do you think @svnpenn ?

from apt-cyg.

 avatar commented on August 25, 2024

If MIT will help with collaboration I vote for that, but personally I dont care as long as the code works.

from apt-cyg.

skl avatar skl commented on August 25, 2024

Agreed.
The version function still echo's "GPL" by the way.

p.s. Thanks for helping out with the repo.

from apt-cyg.

 avatar commented on August 25, 2024

I am innocent on that, it was even on first commit 2af0c86

from apt-cyg.

skl avatar skl commented on August 25, 2024

Not trying to blame, just bringing up as it seemed relevant to this discussion is all.

from apt-cyg.

kou1okada avatar kou1okada commented on August 25, 2024

I appreciate you to clean up about license problem.
But I'm sorry that I brought some troubles to @skl.
Of course, I know GPL string in version function and I commented to there: 2af0c86#diff-f648982bd734e49811c931f511cb33e2R68.
But, unfortunately, I couldn't get answer from Stephen Jungels.

Thanks.

from apt-cyg.

 avatar commented on August 25, 2024

@kou1okada ok then, can we consider this issue closed?

from apt-cyg.

kou1okada avatar kou1okada commented on August 25, 2024

Yes, please.
Thank you for clearing my concern.

from apt-cyg.

 avatar commented on August 25, 2024

@kou1okada @skl 062883c

from apt-cyg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.