Descriptions in Trading Post on TTH are translated by server.

[transhumandesign]

Descriptions in Trading Post on TTH are translated by server.

[diprog]

Yep

[1bardesign]

The descriptions one is interesting. We will need to translate them later on then (clientside).

I wonder about the scrolls. Obviously it's the costs change but it "should" be fine?..

Either way, will need to put out a hotfix for this.

[diprog]

@1bardesign I think we can do something like void TranslateDescriptions()
And put a TranslateDescription(string &in desc) function for all strings.

[diprog]

Hmmm. I've just copied KAG and called it "KAGServer", run it with g_locale = en, joined from normal KAG with g_locale = ru and all descriptions were translated.

[diprog]

Ok, found the problem. It's only TTH, because items are set in rules script WAR.as by server.

[1bardesign]

Ok so this only requires changes to fix the descriptions issue still, correct? I can handle that soon.

[1bardesign]

OK, pushing a fix for this soon;

This is on EN dedi with RU client:

There seems some missing translations for these but I imagine these are in the new translation PRs; hopefully they merge ok!

[1bardesign]

@diprog Please review 77e0f93 and current head on test build and ensure this works as intended, then close. 👍

(test build will be updated with these changes and more within 30min of this post)

[diprog]

hmmm

[diprog]

So, descriptions without icons are not translated

[1bardesign]

Ah, found it. Will push a fix in a minute.

[1bardesign]

Should be fixed in 09e752c

[diprog]

Waiting for the test build then to make sure that everything works fine

[diprog]

It's 7;30, so I need to go to college. Will test it later.

[1bardesign]

No problem. It should have just gone live but I'm not in a rush with this; just close the issue if you're satisfied that it's fixed and thanks for your rigor 🙂

[diprog]

Closed. Don't see any reason for it not to work.