aws-s3-multipart: retry signature request - upload-error event not triggered on loss of network connection - not retrying requests

[JohnDennehy101]

aws-s3-multipart: retry signature request - upload-error event not triggered on loss of network connection - not retrying requests

[JohnDennehy101]

Hi @Murderlon @aduh95, thanks for assigning for further investigation. Just wondering if ye have had a chance to take a look in more detail / will this issue be resolved in a future release?

[macmillen]

This is also happening to me. I blocked the outgoing aws connection to get a timeout error to test the upload-error hook but it never triggers the hook.

[aduh95]

Hello, I'm having trouble reproducing, are you able to reproduce consistently the issue or is there some flakiness involved? Are you trying to upload local files, or files from a remote provider (e.g. Google Drive)? What is the behavior on the DevTools? Do you see an infinite amount of requests being sent (and at what interval are they sent), or is it just one request pending indefinitely?

For the record, I tried to reproduce using yarn dev:with-companion:

• I added uppyDashboard.on('upload-error', function(...args) {debugger}) in private/dev/Dashboard.js to detect if the event is emitted.
• I configured Firefox DevTools to block all https://s3.us-east-1.amazonaws.com/* requests.
• I started to upload a local file.

This is also happening to me. I blocked the outgoing aws connection to get a timeout error to test the upload-error hook but it never triggers the hook.

Can you clarify if you block the outgoing connections from the client or from Companion side?

[JohnDennehy101]

Hi @aduh95,

I have resolved this issue by hardcoding a custom plugin using the code before the change I highlighted was implemented.

I was able to consistently reproduce the issue at the time. Our use case is for uploading large local files to s3 using pre-signed urls returned from companion.

On loss of network connection, the pending requests just remain in that state and the browser just hangs (with the upload progress spinner still displaying that the upload is in progress).

We do not block the outgoing connections from either side.