Issues related to sidecar CMP mode

[travisghansen]

Issues related to sidecar CMP mode

[travisghansen]

v0.3.2 has kustomize installed. Can you point me to the source of the kubevirt (or other chart) which execs? I've never seen that and so will try to run some tests.

[crabique]

Yes, I mean without downloading stuff, same way as argo-cd passes down /var/run/argocd/argocd-cmp-server, so argo-cd could pass down a directory like that with helm/kustomize/kubectl etc, and it can be added to volumeMounts and to PATH, so all of the binaries could be shared across argo-cd and all the CMP plugins.

[travisghansen]

You could create your own init image which has all binaries bundled and then just cp (instead of wget) to the custom tools dir.

[travisghansen]

When the new feature lands in argocd this should just work now e995102

[travisghansen]

Welcome! I probably can’t align perfectly with argo-cd versions but I’m happy to add those tools to the image.

Let me check on the exec issue with someone from the argo team.

[crabique]

Thank you, that is great!

As for the exec issue, it is a bit of a customized setup thing around helm hooks, here is how to reproduce it:

applications/kubevirt/helmfile.yaml

releases:
- name: kubevirt-operator
  chart: manifests/v0.58.1/operator
  hooks:
  - events: ["prepare"]
    showlogs: true
    command: "../../hacks/kubevirt/download.sh"
    args: ["v0.58.1", "operator"]
- name: kubevirt-cr
  chart: manifests/v0.58.1/cr
  needs:
    - kubevirt-operator
  hooks:
  - events: ["prepare"]
    showlogs: true
    command: "../../hacks/kubevirt/download.sh"
    args: ["v0.58.1", "cr"]

../../hacks/kubevirt/download.sh

#!/usr/bin/env bash

set -eo pipefail

KUBEVIRT_URL="https://github.com/kubevirt/kubevirt/releases/download"
KUBEVIRT_VER="$1"
KUBEVIRT_APP="$2"

[[ $KUBEVIRT_VER =~ ^v[0-9]{1}.[0-9]{1,3} ]] || (echo "Kubevirt version does not match regexp, for example v0.57.1"; exit 1)
[[ $KUBEVIRT_APP =~ (operator|cr) ]] || (echo "Incorrect kubevirt app, expected operator or cr"; exit 1)

mkdir -p manifests/$KUBEVIRT_VER/$KUBEVIRT_APP

curl -Lk "$KUBEVIRT_URL/$KUBEVIRT_VER/kubevirt-$KUBEVIRT_APP.yaml" -o "manifests/$KUBEVIRT_VER/$KUBEVIRT_APP/manifest.yaml"

[travisghansen]

Can you exec into the container and find the tmp dir where the data is and see if the files are marked as executable? I’m wondering if something is different in how the data now gets sent to the sidecar which leaves the files without the executable biit.

[crenshaw-dev]

I’m wondering if something is different in how the data now gets sent to the sidecar which leaves the files without the executable biit.

That's exactly it. :-) argoproj/argo-cd#9647

At the Argo CD contributors' meeting yesterday, Alex Matyushentsev said he plans to implement the "preserve executable" config option for the plugin.

For now, the plugin itself can be modified to chmod +x the file.

[crabique]

Ohh... Now I understand what's going on 🙂

For now, I changed it to command: "bash" and moved the script path to args[0], also changed the script to use wget instead of curl, so that nothing needs to be installed additionally. Not the most elegant workarounds but I expect the sidecar-cmp integration architecture will get better in the future, so this is completely fine.

Everything seems to be working perfectly now, thank you for your help!

[travisghansen]

I'll make sure wget/curl are in the images. Any other tools you think would be helpful?

[crabique]

Not at all, argo-cd containers don't have curl either, so previously we were adding it with an init-container, I just didn't get to see it's missing because of the -x error 🙂 Just wget is fine, as it's what is used in the Dockerfile, imo there is no need to bloat the image with something not also present in argo-cd images.

I hope in the future there will be some mechanism to pass down a PATH-able volume from argo-cd and not bundle duplicate stuff with every plugin, but for now I don't see anything obvious missing.

[travisghansen]

You can actually pass down a PATH yes.

Something like this is possible.

#  - name: KREW_ROOT
#    value: /home/argocd/.krew
  - name: PATH
    #value: $(KREW_ROOT)/bin:/opt/custom-tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
    value: /opt/custom-tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin

[crabique]

Very nice, thanks for the quick fix!