intermittent `TypeError: NodeClass is not a constructor` when getting tree nodes

[verhovsky]

intermittent `TypeError: NodeClass is not a constructor` when getting tree nodes

[verhovsky]

I've also just seen this error

Error: Invalid argument
    at get namedChildren [as namedChildren] (/Users/space/code/curlconverter/node_modules/tree-sitter/index.js:166:39)
    at extractCommandNodes (/Users/space/code/curlconverter/src/shell/tokenizer.ts:580:32)
    at tokenize (/Users/space/code/curlconverter/src/shell/tokenizer.ts:722:24)
    at findCommands (/Users/space/code/curlconverter/src/parse.ts:31:12)
    at parse (/Users/space/code/curlconverter/src/parse.ts:58:24)
    at toClojureWarn (/Users/space/code/curlconverter/src/generators/clojure.ts:515:20)
    at Object.toClojure (/Users/space/code/curlconverter/src/generators/clojure.ts:520:10)
    at <anonymous> (/Users/space/code/curlconverter/test/test.ts:95:28)

I re-ran the tests without any changes and got the TypeError: NodeClass is not a constructor error. Re-ran without changes a third time and they passed.

[verhovsky]

It's fairly common actually, it happened in the CI as well

https://github.com/curlconverter/curlconverter/actions/runs/8385221889/job/22963783256?pr=645#step:5:31

[verhovsky]

@segevfiner could this be related to the NAPI changes or something in the upstream tree-sitter C code?

[segevfiner]

It could be... But I'm not really sure what could possibly cause this. Guess some good old fashioned debugging is in order... 😛

[verhovsky]

Turns out #190 (comment) is not related to Jest.

[segevfiner]

@verhovsky The bug seems to be that we are holding a weak reference in cached_nodes_, yet the finalizer hasn't been called yet, as per Node.js docs:

Finalizer callbacks may be deferred, leaving a window where the object has been garbage collected (and the weak reference is invalid) but the finalizer hasn't been called yet. When using napi_get_reference_value() on weak references returned by napi_wrap(), you should still handle an empty result.

[verhovsky]

Fixed by #197