array_reserve does not handle malloc errors

[alaviss]

array_reserve does not handle malloc errors

[maxbrunsfeld]

Yeah, this working as intended. Like @amaanq, Tree-sitter aborts on allocation failure (unless you explicitly override that allocation behavior). Attempting to recover from allocation failure is explicitly not something we plan to do. For most codebases, attempting to do that correctly is a SEGV waiting to happen.

[amaanq]

There is a check if the default ts allocator is used (which the cli does or if you specify -DTREE_SITTER_REUSE_ALLOCATOR) -

tree-sitter/lib/src/alloc.c

Line 5 in 8b28443

static void *ts_malloc_default(size_t size) {

If you are opting out of the ts allocator, then whatever the user supplies is used, or just the function itself if not.

[alaviss]

Is it the intention that grammars should be complied with -DTREE_SITTER_REUSE_ALLOCATOR by default? None of the bindings seem to do that, so we already have SIGSEGV pending on OOM in all bindings.

At the very least I think the fallback implementations based on libc should also abort on failures.