Add Max Heap?

[trekhleb]

Add Max Heap?

[trekhleb]

@bresson yes, please, just feel free add MaxHeap if you want.

I think it should be added in the same folder as MinHeap. We would need to have an AbstractHeap.js class that will be a base class for the MinHeap.js and MaxHep.js just to avoid code duplication. What do you think?

[bresson]

@trekhleb Sounds great! I'll work on a AbstractHeap and MaxHeap first and get a PR, then circle back to refactor MinHeap to inherit from the AbstractHeap.

Quick clarification, Java has dedicated Abstract classes so in JS we're thinking along the lines of following Java's abstract template - a base class which cannot be instantiated and will have abstract and non-abstract methods?

[trekhleb]

@bresson yeah, unfortunately we will need to imitate abstractness. I was thinking about something like this:

class Heap {
  constructor() {
    if (new.target === Heap) {
      throw new TypeError('Cannot construct Heap instance directly');
    }
  }

   // Methods that are common for both Min and Max heaps.
}

class MinHeap extends Heap {
  constructor() {
    super();
  }

  // MinHeap specific methods here.
}

Something like that. Just to avoid code duplication. Maybe it is even not abstractness but rather a parent class that just may not be instantiated.

[bresson]

Sounds great - aiming for PR in about a week unless work interferes.

[kersov]

Hi @bresson, I started to implement MaxHeap before this issue is created.
I have prepared PR #167
but I will change it according to the @trekhleb comment above.

[trekhleb]

Thanks for PR @okersov