Conflict between WebDAV and tests?

[trellis-ldp-archive]

Conflict between WebDAV and tests?

[ajs6f]

Yup, that did it, thanks!

[acoburn]

OK, this is not entirely unsurprising. Because WebDAV doesn't specify the semantics of POST, all resource creation occurs via PUT (i.e. adding a file to a directory is a PUT operation). However, Trellis assumes that PUT for creation will do an uncontained creation of the resource. In order to combine those two patterns, the WebDAV module intercepts all PUT requests for creation and rewrites those as POST with an appropriate Slug header. And thus, because these tests are checking for uncontained PUT, they will fail, since with the WebDAV module in place, an uncontained PUT is not possible.

One possibility that I've been considering anyway involves adding a configuration option such that the behavior of PUT-on-creation can be controlled to either do contained or uncontained creation. (In the past we had the contained PUT in place, but that was changed in 0.8)

[ajs6f]

Ok, cool. That seems fine to me-- I mean we obviously have some design thinking, but this doesn't really represent an error right now. Do you know what the Memento involvement is?

[acoburn]

I wired the webdav module into the triplestore-based application, and I definitely see the test failure with testCreateContainerViaPut. Curiously, I don't encounter the memento errors. All those errors seem to involve using PUT to replace an LDP-NR. Can you verify that PUT for replacing a binary resource works properly in T-C*?

[ajs6f]

It certainly does not with WebDAV in place, for creating or replacing. Is that what you meant, or you meant without WebDAV?

[acoburn]

I meant: does it work properly without WebDAV enabled

But given that the tests were passing previously, I can only assume that the answer is "yes"

[ajs6f]

Yes, those tests normally pass. 😁

[ajs6f]

Would you like a PR to watch in CI?

[ajs6f]

I wonder if this has anything to do with #55.

[ajs6f]

Here is a branch.

[ajs6f]

Definitely improvement: the four Memento tests pass for me now, but I am now getting:

[ERROR] Tests run: 8, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.498 s <<< FAILURE! - in edu.si.trellis.LdpBasicContainerIT
[ERROR] testCreateContainerViaPut  Time elapsed: 0.004 s  <<< ERROR!
java.lang.ExceptionInInitializerError
	at org.trellisldp.test.LdpBasicContainerTests.testCreateContainerViaPut(LdpBasicContainerTests.java:210)
	...
Caused by: java.lang.IllegalStateException: No ConfigProviderResolver implementation found!
	at org.eclipse.microprofile.config.spi.ConfigProviderResolver.instance(ConfigProviderResolver.java:122)
	at org.eclipse.microprofile.config.ConfigProvider.<clinit>(ConfigProvider.java:74)
	... 42 more

You appear to have used the new configuration element there. I guess I now need to have a Microprofile Config impl on line for tests?

[acoburn]

Yes, you'll now need a microprofile config impl for the tests.