Giter Site home page Giter Site logo

Comments (2)

alekseykulikov avatar alekseykulikov commented on July 27, 2024

So we shouldn't set the CLI numberOfRuns if it was just falling back to the actions' default of 1.

I agree with this strategy for now.

the action could just default to the default of the CLI (which is 3 runs)

I don't think that the 3-runs is an optimal default. It may results in a 3x bill with no significant value. 1-run works for static checks, like resource budgets or lighthouse scores. 3-runs makes sense when user tests performance or collect analytics with LHCI Server.

Maybe we could fallback to LHCI default (breaking change for LH v6 release) and show a warning when 3-runs used without an extra value.

from lighthouse-ci-action.

alekseykulikov avatar alekseykulikov commented on July 27, 2024

fixed in treosh/lighthouse-ci-action@v3

from lighthouse-ci-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.