Git pre-push hook to `lint --fix` the project

[andretchen0]

Git pre-push hook to `lint --fix` the project

[alvarosabu]

Here is the task Tresjs/configs#4

[alvarosabu]

Hi @damienmontastier Antfu's config extends the eslint vue rules with some opinionated overrides (which I agree) https://github.com/antfu/eslint-config/blob/main/src/configs/vue.ts

You can check the tres eslint config here https://github.com/Tresjs/eslint-config

[andretchen0]

Hey @alvarosabu !

• I've got a working solution. It uses the husky plugin. Is that ok with you?
• Is this something we want to eventually add to other projects in the ecosystem? If so, I'll start with Cientos as it's where I'm working right now.

[andretchen0]

Hi, @andretchen0 sounds good, so the pre-commit of husky will lint fix then?

Yeah.

Husky is a plugin that makes git hook configuration a bit more straightforward.

The usual git commit, push, etc. commands won't change. They'll trigger a git hook configured by husky.

[alvarosabu]

Sounds good, I'm planning to refactor @tresjs/eslint-config to extend https://github.com/antfu/eslint-config flat config and using ESLint Stylistic. I did it with my personal eslint config last week to test it and it works fine.

[damienmontastier]

Hey @alvarosabu. Wouldn't using ESLint Vue or extending it be more viable for Vue's "good practices"?

[alvarosabu]

Hi, @andretchen0 sounds good, so the pre-commit of husky will lint fix then?

[andretchen0]

Made a PR on Cientos:

https://github.com/Tresjs/cientos/compare/chore/git-pre-push-lint?expand=1

[andretchen0]

Closing here on TresJS as there's now a PR on Cientos. Continuing the discussion there.