Comments (15)
That'd be super cool. I was also thinking about something like a splash screen. When you start a workflow you'd start by confirming a coin's logo (maybe bitcoin default?).
from trezor-firmware.
Please keep the public conversation in English.
from trezor-firmware.
Also consider showing a network in cases where we support a number of them
from trezor-firmware.
https://github.com/trezor/trezor-common/tree/master/defs/coins now contains coin icons, so we can use that as well. Question is whether the coin icons are still recognizable if we downscale them to e.g. 16x16 pixels.
from trezor-firmware.
And what about altcoins icons that are not Bitcoin fork?
from trezor-firmware.
And what about altcoins icons that are not Bitcoin fork?
No worries, we won't leave them out. We add the icons if necessary
from trezor-firmware.
We're passing this one from one milestone to another. I don't think this makes sense to do before (or jointly with) #53.
from trezor-firmware.
We need to discuss with Peter how to prevent selecting the wrong coin with a similar shortcut (probably an icon).
from trezor-firmware.
Part of #53
from trezor-firmware.
Since we are currently limiting derivation paths to each coin this is less important than it used to be. The design and Suite should also help with this significantly. Therefore we have decided in the Product team we do not want to implement this at the moment.
from trezor-firmware.
Since we are currently limiting derivation paths to each coin this is less important than it used to be.
That's a weird rationale.
The original issue is that the user can be confused/tricked into signing a transaction of the wrong funds on the wrong chain. So this very much still exists regardless of derivation paths. This is purely a UX issue, Suite can't help because it is on the host side, so "design" is the only place to resolve this, and I think that this issue is specifically about "keep this thing in mind for a redesign".
from trezor-firmware.
The original issue is that the user can be confused/tricked into signing a transaction of the wrong funds on the wrong chain.
Our rational was that the user can no longer be tricked because when they are on coin X they can't use paths for Y. But you raising a point when user would like to use X coin with X paths but is tricked to use Y coin with Y paths, do I understand it correctly?
Our rational was that in transaction signing Trezor displays the amount with the coin abbreviation so user should notice if they are signing ETH instead of BTC. But you are right that the difference between BTC and BTG for example is very small. And in message signing Trezor enforces the prefix so that should be fine as well. But the first point is something we should reconsider.
from trezor-firmware.
user would like to use X coin with X paths but is tricked to use Y coin with Y paths, do I understand it correctly?
(...)
difference between BTC and BTG for example is very small
Exactly. Plus, this is even more relevant in case of tokens.
from trezor-firmware.
I think that this issue is specifically about "keep this thing in mind for a redesign".
We have discussed this with @matejzak with respect to the new redesign and he was against it. Mainly due to the maintenance reasons mentioning it was not that easy to make the icons nice and clean in Suite. He was strongly advocating for Trezor's design to be clear and simple. So I am suggesting to close this one unless we feel we really need it due to security concerns.
from trezor-firmware.
Please reopen if the rationale above does not seem sufficient.
from trezor-firmware.
Related Issues (20)
- Make loaders more fluent
- Building on Aarch64 (GCC 13 and Python 3.12) HOT 4
- improve robustness of i2c communication by using DMA
- Improve waking optiga from sleep mode
- Add BOOTLOADER VERSION and BOARDLOADER VERSION to prodtest HOT 1
- Passphrase flows
- "Previous" instead of "Back/Cancel" during Backup recovery/dry run
- Fix backlight timer setting
- Move backlight control fully into Rust
- Homescreen/Lockscreen
- Backup check/Dry run flow
- rounded rect rendering bug
- Swipe up animation between receive address and tap to confirm screen after tap to confirm animation
- Send ETH (EVM)
- Persistent words in recovery
- Screen transitions
- Show last typed PIN number for short period of time before changing it to "*"
- use `storage.cache.set_bool`
- Check backup - wrong Suite response
- Better integration of Slip39_Single backup type
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from trezor-firmware.