Bug report for `trillium-method-override`: Not converting from method field in request body

[trillium-rs]

Bug report for `trillium-method-override`: Not converting from method field in request body

[jbr]

I'm going to tentatively close this because it seems like this needs to be application-specific, since there are any number of body encodings that the trillium-method-override library doesn't/shouldn't know about

[jbr]

Hey, sorry for the delay on this!

To make sure I understand your suggestion, the goal is to parse the body and check for a given attribute that modifies the http method along the lines of trillium-method-override, which currently only uses a url param? Let me know if I misunderstood the intent

I don't think there's currently a good way to provide a library that does this that can support arbitrary body encodings (json, xml, x-www-urlecoded, etc). I think this is the sort of thing that would be best to handle in an application, by parsing the body from whatever format and putting that into conn state, as well as modifying the method.

[jalcine]

Hm, that makes sense! I think I can add this on my side, but I'd need to figure out how to change the method while a request is being processed. It looks simple enough to do reading https://docs.trillium.rs/src/trillium_method_override/lib.rs.html#94-108

(Originally published at: https://jacky.wtf/2022/5/r-Er)

[jbr]

Yep, it's really just conn.inner_mut().set_method(method); (using trillium_http::Conn::set_method) — And Method has a try_from(&str)