Kernel tests for Chado Storage

[laceysanderson]

Kernel tests for Chado Storage

[laceysanderson]

Current state of things is described fully in the PR referenced above.

Summary from PR:

This PR adds a new Test Trait to make it easier to write Kernel tests for Chado Storage. As mentioned in the linked issue, the plan is to write a full suite of Chado Storage kernel tests for each field. This PR lays the ground work for that and adds an example test for the property field.

NOTE: When looking at the property test you will notice that the data provider would provide two test datasets except that the second one is commented out. This is because the second one currently fails due to #1398.

ChadoLinkerPropertyDefault Field

tripal_chado/tests/src/Kernel/Plugin/ChadoStorage/ChadoLinkerPropertyDefaultTest.php

The $fields array describes the hypothetical fields and properties to test. For this test, there are two property fields whose chado storage properties match the form currently used in this field. It also provides a single "other" field which contains properties to meet the unique constraint for feature.

The dataProvider provideFieldExpectations() currently provides one set of expectations which includes the values for a single property field and the other field. As noted above, there is a second set of expectations which is commented out currently that allows us to test multiple property fields attached to the same content type... However, it is not currently being used in tests due to Issue #1398.

testInsertValues()

Currently tests ChadoStorage addTypes(), getTypes(), insertValues() methods for expectation sets provided by the data provider. This is written/tested to work once we uncomment the second expectation set.

I still have the following tests to implement for this field but will do so in another PR as this one was already becoming substantial.

• Create Values in Chado using ChadoStorage when they violate unique constraint.
• Load values in Chado using ChadoStorage when they don't yet exist.
• Load values in Chado using ChadoStorage after we just inserted them.
• Update values in Chado using ChadoStorage after we just inserted them.
• Update values in Chado using ChadoStorage when they don't actually exist.
• Ensure property field picks up records in Chado not added through field.

[laceysanderson]

With PR #1584, we now have a full test suite for a single property field. The next step are:

• to resolve bugs known bugs in the property field
• to document this new API for testing the chado interaction of fields
• to write similar tests for other existing fields

[laceysanderson]

Closing because this is more a documentation issue at this point.