Package breaks when using import assertions

[Csszabi98]

Package breaks when using import assertions

[chentsulin]

After upgraded to prettier 3.1.1, the error message is changed from SyntaxError: ';' expected. to SyntaxError: '{' expected.

[chentsulin]

Another requirement is to bump @babel/generator to >=7.22.0:

prettier-plugin-sort-imports/package.json

Line 36 in 61d0697

"@babel/generator": "7.17.7",

Ref: https://github.com/babel/babel/releases/tag/v7.22.0

[MillerSvt]

You can use ["importAttributes", { deprecatedAssertSyntax: true }] to support both new and legacy syntax.

it is not working

[fisker]

You can use ["importAttributes", { deprecatedAssertSyntax: true }] to support both new and legacy syntax.

[CHC383]

@ayusharma @byara Could someone please review #293 or #273?

[chentsulin]

We need to allow passing the importAttributesKeyword option to babel-generator:

prettier-plugin-sort-imports/src/utils/get-code-from-ast.ts

Line 51 in 61d0697

const { code } = generate(newAST);

If the importAttributesKeyword option is undefined, babel unexpectedly transforms with { type: 'json' } to with type: 'json' (with-legacy): https://github.com/babel/babel/blob/8fa2a916e0bb601e728c3d368c1e271763880f40/packages/babel-generator/src/generators/modules.ts#L102-L106

Ref: https://babeljs.io/docs/babel-generator

[JulianCataldo]

I have the same problem. I tried to fiddle but the Babel parser importAttributes isn't working, while importAssertions does work. That is a blocker, so I had to disable the plugin altogether, so I can still continue to format the document as needed.

[vincerubinetti]

Is there any solution to this, even just a way to make a prettier lint check or in-IDE check not fail? I tried // prettier-ignore, // sort-imports-ignore, // @eslint-disable-next-line, using importAttributes vs importAssertions, with vs assert, nothing works.

I need to have this because I'm importing some JSON into a Playwright test and it can't handle it without the assert for some reason.

[MillerSvt]

@CHC383 I think I'll post a fork if it's not reviewed this week.