Giter Site home page Giter Site logo

Comments (4)

Trung0246 avatar Trung0246 commented on September 24, 2024

Hm this sounds almost impossible to implement for Junction due to the bookkeeping of array and dict object behind the scene. I guess a separate node for this makes more sense. Maybe Mirror that can detect if a Highway or Junction being connected then it will mirror accordingly.

I guess the basic implementation is something like this:

4 static pins: _data_in, _data_out, _layout_in, _layout_out.

All will accept junction or highway, but behave differently. Data pins will act like expected for transfer the data, while layout pin when connected with junction or highway node it will mirror the layout of the connected node. Maybe I could extend this by allowing multiple layout pins and therefore multiple different nodes and not just layout or junction are accepted.

from comfyui-0246.

alessandroperilli avatar alessandroperilli commented on September 24, 2024

It's possible I didn't explain myself properly. I'll try again.

What I am asking is that the Junction node behaves as follows:

Moment 0 - No inputs is connected and Junction only has a _junc_in and _junc_out pins + the ... pin.
Moment 1 - The user connects the first input. Let's say an image input.
Moment 2 - Junction automatically shifts the ... pin down (that's already happening) and creates an image output pin, just below the _junc_out pin, without the user having to specify anything.
Moment 3 - The user connects a second input. Let's say it's a latent input.
Moment 4 - Junction automatically shifts the ... pin down (that's already happening) and creates a latent output pin, just below the image output pin, without the user having to specify anything.
Moment 5 - etc.

This is what I meant by "mirroring". I simply would hope to avoid the manual definition of the outputs within the same node.

from comfyui-0246.

Trung0246 avatar Trung0246 commented on September 24, 2024

Hm I see. Yeah this will be a separate node.

from comfyui-0246.

Trung0246 avatar Trung0246 commented on September 24, 2024

Closing since [EPIC] has been created.

from comfyui-0246.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.