OpenStep style "menu button" behavior

[trunkmaster]

OpenStep style "menu button" behavior

[armm77]

Interesting proposal, it is better to suppress the event.

[trunkmaster]

Excellent. I'll continue this discussion once I get into this closer. What I see right now we need to add new GNUstep defaults settings to be able to switch on/off menu button and to set left/right mouse button.

[trunkmaster]

@ratmice my first experiment shows me no trouble for mouse button event redirection. To be more specific:

• I've implemented right mouse button press/release event redirection to active (focused) window if right mouse button event occurs on root window in WindowMaker part of Workpace;
• GNUstep application shows it's app menu right under cursor, on button release app menu disappears;
• X applications does nothing. No errors in console. I've checked Emacs, Firefox, GIMP.
  What applications did you have troubles with? What X11 errors did they produce?
  I've not pushed any changes to repo yet.
  Anyway, I have another solution/proposal: check if focused window class is GNUstep and make desicion to redirect event or show Workspace application menu (as option: show WindowMaker root menu if Menu Button disabled in Preferences).

[ratmice]

@trunkmaster cool, IIRC (it has been a number of years)

the issues i was seeing were:

• GNUstep application menu not dissapearing under some circumstances (single clicking, or mouse up outside of the window perhaps)
• segfault in firefox(?), perhaps valgrind caught this and it was fixed in the mean time
• extraneous logging when running from terminal w/ gnome applications,

Will edit your additional proposal into the top issue.

[trunkmaster]

@ratmice now changes are in the master. You need to reinstall Workspace. Also, I've changed Preferences-Mouse to enable/disable desktop menu (not inwindow app menu yet).
Try it and tell me what do you think.

[trunkmaster]

@ratmice Desired behaviour implementation completed.
Changed components are: Frameworks:NXSystem, Applications: Preferences and Workspace.
Please, reinstall and test. I'm waiting for your feedback.

[ratmice]

@trunkmaster sorry for the delay (distro doesn't have all the dependencies), trying to get that sorted out
look forward to trying it out, hopefully i can get it all sorted before holiday travels.

[trunkmaster]

@ratmice No problem. I'm waitng for your comments before closing the issue.

[trunkmaster]

@ratmice, Do you have any news? Did you try it?

[ratmice]

I have attempted to, but haven't manage to get it to build via RPM,
i managed to build it manually but something went awry, and windowmaker starts up,
but doesn't function correctly.

if you are happy that the issue is fixed by all means close, when I get it working i can reopen or open another issue perhaps. Sorry that i have not managed to get it working.

[trunkmaster]

Current implementation fits me. Of course, there are still many places in Workspace for fixing and polishing. I plan to make an intensive Workspace testing. I close this issue.
Please file separate issue if you have some awkward behaviour of Workspace.