HTTP gem does not work with this gem

[trusche]

HTTP gem does not work with this gem

[maximeg]

I did stumble on that on one personal project (and hopefully, we weren't affected at work due to binary only responses).

I was going to make a PR for that this morning.

The culprit is the new added .dup in HttpLog#log_body:

data = parse_body(body.dup, mask_body, encoding, content_type)

With that, you have two instances of HTTP::Response::Body. The first one to be "read" (by using to_s) will consume the response from the connection. The other to be read will get nothing.

If the content type is "loggable", the instance in httplog is read and the instance you get is empty. If binary (hence not "loggable"), that's the response you get.

A proper way is:

• not dup here, but in parsse_body if needed
• call to_s explicitly before that instead of relying on the implicit to_s of the string interpolation.

[kapso]

Thanks, @maximeg

Curious when this fix will be released?

[trusche]

Well that's not good... :) Checking now

[trusche]

Well, it works fine with ruby 2.6.5 for me. With this setup:

# Gemfile
source 'https://rubygems.org'
ruby '2.6.5'

gem 'http'
gem 'httplog', '1.4.0'

# test.rb
require 'http'
require 'httplog'

puts HTTP.get('http://example.com').body.to_s

running bundle exec test.rb logs the request and spits out the content of example.com. Checking ruby 2.7 now...

[trusche]

Works the same for me with ruby 2.7.0. http gem version is 4.3.0 - which one do you have? And can you provide a minimum example that reproduces the issue?

[kapso]

I am using gem 'http', '4.3.0'