Giter Site home page Giter Site logo

Comments (7)

Shelob9 avatar Shelob9 commented on September 16, 2024 1

I'd like to pass URL variable of an access key from Help Scout to the Access Key Login form.

  1. Check if its in the query and if so, add it to the window.tlVendor.accessKey array. https://github.com/trustedlogin/vendor/blob/main/admin/trustedlogin-settings/init.php#L31
  2. If window.tlVendor.accessKey.key, use that value for a hidden field instead of the input https://github.com/trustedlogin/vendor/blob/main/admin/components/AccessKeyForm.js#L204
  3. Add a second conditional here to submit for if window.tlVendor.accessKey.key https://github.com/trustedlogin/vendor/blob/main/admin/components/AccessKeyForm.js#L121
  4. Figure out how to deal with account ID https://github.com/trustedlogin/vendor/blob/main/admin/components/AccessKeyForm.js#L176

from trustedlogin-connector.

zackkatz avatar zackkatz commented on September 16, 2024

Status:

  • ✅ Shows the active logins
  • ✅ Points to the right URLs
  • ❌ Passes validation to redirect to site login

Getting a bad_nonce error, since the nonce is old.

from trustedlogin-connector.

zackkatz avatar zackkatz commented on September 16, 2024

I'd like to pass URL variable of an access key from Help Scout to the Access Key Login form.

  • It will be encrypted using the Help Scout secret.
  • It will be decrypted and added to the form.
  • The form will auto-submit when loaded.

@Shelob9 See what I mean in this video.

from trustedlogin-connector.

Shelob9 avatar Shelob9 commented on September 16, 2024

When that request passes nonce validation, it just outputs JSON. Instead, it should redirect to the site using the $_POST trick in

That's all done client side though. https://github.com/trustedlogin/vendor/blob/main/admin/components/AccessKeyForm.js#L92-L115

We could use wp_remote_post(loginurl) and then do a redirect(siteurl). That should work.

from trustedlogin-connector.

Shelob9 avatar Shelob9 commented on September 16, 2024

Allow a way for requests sourced from HS to bypass nonce validation while remaining secure

Nonces change based on who is logged in: user ID is one of the inputs of the hash. I don't think nonce validation should be used. If the signature matches, then its valid.

from trustedlogin-connector.

Shelob9 avatar Shelob9 commented on September 16, 2024

@zackkatz All of the discussion in this issue is RE: Helpscout return, not EDD integration. Also, we found the EDD integration is in place. So can we close this issue?

from trustedlogin-connector.

zackkatz avatar zackkatz commented on September 16, 2024

Yep, let's close.

from trustedlogin-connector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.