Incorrect PublicKey and Address for Bitcoin

[trustwallet]

Incorrect PublicKey and Address for Bitcoin

[alejandro-isaza]

Private key is always 32 bytes. How are you running into this problem?

[vikmeup]

@Ikloo can you message me on telegram: @vikmeup

[alejandro-isaza]

Hey @Ikloo thanks for reporting. Fixing.

[Ikloo]

@alejandro-isaza awesome, thank you!

[Ikloo]

@alejandro-isaza but isValid(data: Data) -> Bool func from PrivateKey start works incorrect:

public final class PrivateKey: Hashable, CustomStringConvertible {
    /// Validates that raw data is a valid private key.
    static public func isValid(data: Data) -> Bool {
        // Check length
        if data.count != Ethereum.privateKeySize {
            return false
        }

        // Check for zero address
        guard data.contains(where: { $0 != 0 }) else {
            return false
        }

        return true
    }

Problem there: if data.count != Ethereum.privateKeySize 😞

[Ikloo]

@alejandro-isaza Sorry, I misunderstood this logic. 😅
All work as expected! Thank you! 🙏