Comments (4)
Definitely agree with removing the close button, address, and horizontal dl styling. Agree with keeping the unstyled list class and getting rid of the nav ul/ol selector too – can simply put the unstyled class on these elements if you need that styling that way.
Blockquote I’m not sure about whether we should remove – it’s quite a useful thing to have as it’s often used on sites. Any reason in particular you wanted to scrap?
from kickoff.
Thanks @ashleynolan, I felt that the blockquote is not useful enough to keep. It is one of those things that would change on almost every project & not integral to the framework. I don't mind keeping it, just wanted to gauge opinions.
I'll remove the others.
from kickoff.
After thinking about it some more, I'd like to remove some more of the button styles:
Large, Small, Pill, Block & Natural Buttons
I just don't think that they're used often enough. Perhaps the .btn--block
could stay but I'm fairly certain the rest can be safely removed.
// Button Modifiers
// --------------------------------------------------
// These all follow the same sizing rules as above; text is 1em, space around it
// Large
.btn--large {
@include font-size($type-large);
line-height: 3;
height: 3em;
padding-right: 2em;
padding-left: 2em;
border-radius: 6px;
}
// Small
.btn--small {
@include font-size($type-small);
line-height: 1.5;
height: 1.5em;
padding-right: .75em;
padding-left: .75em;
border-radius: 3px;
}
.btn--pill {
padding-left: 1.5em;
padding-right: 1.5em;
border-radius: 100em;
}
// Block button
// -------------------------
.btn--block {
display: block;
width: 100%;
padding-left: 0;
padding-right: 0;
// Vertically space out multiple block buttons
// same ad .btn--block + .btn--block
& + & {
margin-top: 10px;
}
}
// Specificity overrides
input[type="submit"],
input[type="reset"],
input[type="button"] {
&.btn--block {
width: 100%;
}
}
// Make the button inherit sizing from its parent.
.btn--natural {
vertical-align: baseline;
font-size: inherit;
line-height: inherit;
height: auto;
padding-right: .5em;
padding-left: .5em;
}
What do you think?
from kickoff.
I removed .btn--large
, .btn--small
, .btn--pill
& .btn--natural
but kept .btn--block
from kickoff.
Related Issues (20)
- kickoff-react HOT 2
- Docs site down HOT 4
- Kickoff 8 checklist HOT 20
- Fix SVG minification HOT 3
- Finalise SVG sizing & correct CSS workflow
- Form themes HOT 1
- Hot module reloading HOT 1
- Production build requires optional dependencies HOT 5
- Generated CSS file not respect the name given in config.js HOT 1
- Kickoff Builds HOT 3
- problem with current grunt-contrib-imagemin version in package.json HOT 7
- When selecting statix in Yeoman generator missing comma in Gruntfile HOT 1
- Issue with grunt-icon/NPM, causing error HOT 1
- Remove Placeholder Mixin
- Version 7 - TODO HOT 27
- Moving to Gulp HOT 1
- KO FlexGrid HOT 11
- Broken link in Docs HOT 1
- Error in styleguide.scss HOT 3
- IE11 Printing Issue HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kickoff.