Giter Site home page Giter Site logo

Comments (4)

dig3 avatar dig3 commented on July 21, 2024

Thanks for the feedback. I think I'll have to change the window references too. Certainly, make it usable on server-side is one of the thing I want to do.

from fetch-it.

AsaAyers avatar AsaAyers commented on July 21, 2024

It looks like you're using Babel, so you can just use global and it will be window in the browser and global in Node.

I actually wonder if you should even import fetch. Wouldn't it be better to just let the app import a fetch implementation and just use whatever is attached to global?

from fetch-it.

dig3 avatar dig3 commented on July 21, 2024

@AsaAyers that make sense! Change the references to window for global, and run some test to verify if fetch, Promise and other stuff is there. If not throw an error. What do you think?

from fetch-it.

AsaAyers avatar AsaAyers commented on July 21, 2024

I think it should do some test to see if you can discover fetch and throw if it's missing.

Babel can polyfill Promise for you.

let promise = Promise.resolve(request);

You get a result something like this:

var _Promise = __webpack_require__(394)['default'];
var promise = _Promise.resolve(request);

If you try that route, take a look at the compiled output to verify that Babel's promise is included. The ReactA11y project used the babel runtime, but it wasn't compiled into their project and it spawned quite a few issues.

from fetch-it.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.