Wrong type generation / inference when joining a table with itself

[lunedis]

Wrong type generation / inference when joining a table with itself

[lunedis]

You are correct, everything seems to work now. Sorry for the confusion, was most likely an old version or database problem on my part. My bad.

The issues in both my reproduction repository and my main project are fixed. Thanks a lot again for the quick response and for developing this awesome tool!

[Newbie012]

Thanks for the detailed reproduction. I'll raise a fix.

[Newbie012]

fixed in 3.0.0

[lunedis]

Thank you for the quick response, but I don't believe the issue is actually fixed.

Weirdly enough in my main (internal) project, it still generates the "main table" fields with | null (which I think is wrong).

I updated my reproduction repository (https://github.com/lunedis/safeql-recursive-bug) and now it thinks bossName is not nullable (https://github.com/lunedis/safeql-recursive-bug/blob/main/src/main.ts#L10), which I think is also wrong.

Sadly I haven't gotten around to digging into your codebase, else I'd try to fix it myself.

[Newbie012]

Hey @lunedis, I cloned and followed your instructions in the README.md and this is what I get when running eslint:

After fixing the types, eslint doesn't report any other errors:

I already have a test that covers this case:

safeql/packages/generate/src/generate.test.ts

Lines 1155 to 1176 in 2f8b816

	await testQuery({
	query: `
	SELECT
	caregiver.id as caregiver_id,
	self.id as self_id
	FROM caregiver
	LEFT JOIN caregiver self ON caregiver.id = self.id
	`,
	expected: [
	["caregiver_id", { kind: "type", value: "number" }],
	[
	"self_id",
	{
	kind: "union",
	value: [
	{ kind: "type", value: "number" },
	{ kind: "type", value: "null" },
	],
	},
	],
	],
	});

Can you share with me a failing CI execution so I could better reproduce the error?