Comments (10)
Hello @EinfachHans
You've right, but changing that is probably a breaking change :(
Let me get a time to test if it's possible.
See you
Romain Lenzotti
from tsed.
@Romakita maybe we could make this as a "opt-in" feature first via the configuration, then change the default & deprecate in next major and remove the config again in the next major after that?
from tsed.
Yes, when can try to do that.
The problem is probably located here:
I'm a bit over staffed to do that. But If somebody had a time to add the opt-in, I'll be happy to review the PR ;)
It doesn't seems to be a huge work to add that :)
See you @EinfachHans
Romain
from tsed.
@Romakita Do you have a suggested name for the config parameter?
from tsed.
Hum π ... maybe appendNestedRoutesBefore ?
from tsed.
@Romakita just want to start a new PR. I tried to get the tests run in the current production branch, without changed made and get the following error:
@tsed/engines: β ERROR: Error: Cannot find module '/Users/einfachhans/IdeaProjects/tsed/tools/mocha/register' imported from /Users/einfachhans/IdeaProjects/tsed/node_modules/mocha/lib/nodejs/esm-utils.js
@tsed/engines: Did you mean to import "/Users/einfachhans/IdeaProjects/tsed/tools/mocha/register.js"?
@tsed/engines: at finalizeResolution (node:internal/modules/esm/resolve:265:11)
@tsed/engines: at moduleResolve (node:internal/modules/esm/resolve:933:10)
@tsed/engines: at defaultResolve (node:internal/modules/esm/resolve:1157:11)
@tsed/engines: at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:390:12)
@tsed/engines: at ModuleLoader.resolve (node:internal/modules/esm/loader:359:25)
@tsed/engines: at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:234:38)
@tsed/engines: at ModuleLoader.import (node:internal/modules/esm/loader:322:34)
@tsed/engines: at defaultImportModuleDynamically (node:internal/modules/esm/utils:197:36)
@tsed/engines: at importModuleDynamicallyCallback (node:internal/modules/esm/utils:219:12)
@tsed/engines: at Object.exports.doImport (/Users/einfachhans/IdeaProjects/tsed/node_modules/mocha/lib/nodejs/esm-utils.js:35:34)
@tsed/engines: at formattedImport (/Users/einfachhans/IdeaProjects/tsed/node_modules/mocha/lib/nodejs/esm-utils.js:9:28)
@tsed/engines: at exports.requireOrImport (/Users/einfachhans/IdeaProjects/tsed/node_modules/mocha/lib/nodejs/esm-utils.js:42:34)
@tsed/engines: at exports.handleRequires (/Users/einfachhans/IdeaProjects/tsed/node_modules/mocha/lib/cli/run-helpers.js:94:34)
@tsed/engines: at async /Users/einfachhans/IdeaProjects/tsed/node_modules/mocha/lib/cli/run.js:349:25 {
@tsed/engines: code: 'ERR_MODULE_NOT_FOUND',
@tsed/engines: url: 'file:///Users/einfachhans/IdeaProjects/tsed/tools/mocha/register'
@tsed/engines: }
Any idea why?
from tsed.
Just run test for the concerned package ;)
Run entire test on this repo will take along time.
Also have you installed the project using Λyarn install` ?
See you
from tsed.
Yes, only running the platform-router
tests works, but anyway it's weird that i can't run the engine tests in a new fresh environment. Of course i installed the dependencies, i followed the contributing guide π€
from tsed.
π Are you happy?
If you appreciated the support, know that it is free and is carried out on personal time ;)
A support, even a little bit makes a difference for me and continues to bring you answers!
from tsed.
π This issue has been resolved in version 7.70.0 π
The release is available on:
v7.70.0
- GitHub release
Your semantic-release bot π¦π
from tsed.
Related Issues (20)
- [BUG] DI resolves `alias` tokens non-deterministically HOT 4
- [BUG] @Nullable decorator does not work with unions of various objects HOT 3
- [BUG] MultipartFile doesn't show file input in Swagger HOT 1
- FormData property not available from BodyParams in a Middleware HOT 17
- [BUG] Invoke Error in platform-serverless on SQS event HOT 2
- [BUG] New implementation of "nullable" decreases the accuracy of ajv errors. HOT 4
- [BUG] @Integer annotation is no more taking into model when used with @Nullable(Number) HOT 12
- [BUG] TypeError in JsonDeserializer when handling Array of Maps HOT 9
- Run BullMQ workers $onReady? HOT 1
- [ERROR] [TSED] - TypeError: Cannot read properties of undefined (reading 'paramType') HOT 2
- Feat: Disable axios behavior HOT 23
- Option to disable cache control when caching endpoints
- [BUG] adding optional path paramater duplciates the endpoint in swagger HOT 3
- [Bug] micromatch dependency vulnerable to CVE-2024-4067 HOT 3
- [BUG] Unexpected "export" statement in ES module "PlatformLogMiddlewareSettings.js" HOT 7
- [BUG] Failed to install package @tsed/testcontainers-mongo HOT 2
- Support for computed fields in prisma plugin? HOT 8
- [BUG] jest tests fail starting from 7.80.0 HOT 6
- [BUG] Unexpected 'style' property when referencing an enum
- [V8] Roadmap
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tsed.