Keys.filter() will not filter out an object property that equals an empty object.

[tselect-npm]

Keys.filter() will not filter out an object property that equals an empty object.

[SylvainEstevez]

@bjamba Thanks for raising the question. I actually spent quite some time thinking on the best way to deal with empty objects when I wrote the filter utility.

What behavior would you see happening for the following example?

Key.filter({ a: {}, b: { foo: 'bar' } }, ['!a', '!b.foo'])

Would you see the result to be {} or { b: {} }?

[bjamba]

I'm currently seeing the result as { a: {} }. I think if I were to think about what I would like to see in that instance, I'd think I'd like to see { b: {} }, since if we're nesting into properties.

I guess to put it another way, the way I imagine the filters could work is so that if you are explicitly filtering out a parent key, it should filter out anything that's a child of it. But if I'm filtering a child key that would effectively render the parent key to be an empty object, we preserve the object.

[bjamba]

Hi, circling back on this to ask if there had been any additional thoughts on solving this issue or if there was more clarification on my end that was needed. Thanks!

[SylvainEstevez]

@bjamba Sorry for not getting back to you earlier. What you are saying makes total sense and I'll provide a fix within 10 days. If you wish to make a PR yourself, that's even better!