Type definition in v1.3.4 overrides local Vue type definitions

[tserkov]

Type definition in v1.3.4 overrides local Vue type definitions

[tserkov]

Hi @tonythomson, I'm sorry to hear that!

According to the Vue documentation and Typescript documentation:

1. You can’t declare new top-level declarations in the augmentation — just patches to existing declarations.

This also how other plugins implement typings: example 1 example 2

So I'm not entirely sure how this is technically possible. Would you be able to provide a minimal example that reproduces the issue?

Thanks!

[tonythomson]

Thanks for the links, @tserkov ! They gave me some examples with which to regress. Neither of those libraries, when imported into my project, causes the same error. I believe I've tracked down the difference.

In the typings file for vue-plugin-load-script, we are missing the import statement for Vue, listed by the Vue docs linked above as necessary. If I put the import at the top into the module's typings file, my compilation errors disappear.

Not a TS expert, but I believe that what is happening is that without the import, my local type defs are defined on the Vue object, then when the module's types are loaded, if the import is present, the types are applied to augment the already-augmented Vue instance. Without the import statement, the type definitions is applied to the original Vue object, losing any interim type definitions. Regardless of reason, restoring the import fixes things. I'll open a PR for your consideration.

[tserkov]

🤦🏻‍♂️ oof, such a rookie mistake! Thanks for catching that, I'm looking at the PR now. :)