Giter Site home page Giter Site logo

Broken header markup about redmine-theme-flat HOT 9 CLOSED

tsi avatar tsi commented on July 26, 2024
Broken header markup

from redmine-theme-flat.

Comments (9)

tsi avatar tsi commented on July 26, 2024

Sorry, I can't reproduce this issue on my end.
Is this page public? could you share a page to demonstrate the issue?

from redmine-theme-flat.

ArmorDarks avatar ArmorDarks commented on July 26, 2024

Unfortunately, page isn't public.

There won't be difference between viewing that page in your Redmine, or in ours. It will have same effect, since markup and css is same.

The issue related to the wrong position of the element in flow.

One important thing which I must admit, thought, that as I've discovered, issue persist only in Chrome, not Firefox. Tested in 37 and 39 versions.

from redmine-theme-flat.

tsi avatar tsi commented on July 26, 2024

I'm having chromium 36 on this machine and all is fine.
Do you think this is a new issue in 37?

from redmine-theme-flat.

ArmorDarks avatar ArmorDarks commented on July 26, 2024

I've already encountered similar issue with unexpected elements flow in older project, so I can't say exactly.

But considering you don't see it, it may be.

It's important to force refresh page. It won't appear if you'll switche between sections of Redmine, for example.

For instance, here is page after I clicked "Projects" section:

And after I clicked "Refresh page":

from redmine-theme-flat.

mrhyde avatar mrhyde commented on July 26, 2024

We just tested it in Chrome Canary build 39 and the problem is still there. Basically as soon as you send a HTTP request with header Cache-Control:no-cache, you get that weird rendering behavior.

from redmine-theme-flat.

mrhyde avatar mrhyde commented on July 26, 2024

We even have installed Chromium v37 on our linux machine and as you can see on the screenshot - problem persists.

from redmine-theme-flat.

tsi avatar tsi commented on July 26, 2024

I've updated to chromium 38 and still can't reproduce the issue.
A simple solution would be to move the pseudo-element into the h1.
could you please test if replacing the 2 #header:before with #header > h1:before helps?
Thx

from redmine-theme-flat.

ArmorDarks avatar ArmorDarks commented on July 26, 2024

Yeap, that works.

from redmine-theme-flat.

tsi avatar tsi commented on July 26, 2024

Merged. Thanks!

from redmine-theme-flat.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.