Giter Site home page Giter Site logo

Comments (5)

Tslat avatar Tslat commented on August 16, 2024

Which version are you trying to use?

from smartbrainlib.

Jamalam360 avatar Jamalam360 commented on August 16, 2024

1.9 on 1.19.2

from smartbrainlib.

Tslat avatar Tslat commented on August 16, 2024

And what issue are you having.. exactly?

That setup is working fine for me in dev currently and for plenty of others

from smartbrainlib.

Jamalam360 avatar Jamalam360 commented on August 16, 2024

The wiki suggests depending on both the Fabric and Common jars.

Decompiling these artifacts from the maven, the Fabric jar is in intermediary mappings as expected, but the common jar is not, it is in mojmap.

This means that people that don't use mojmap (i.e. yarn/quilt mappings user) cannot depend on the common jar.

Decompilation of random class to show issue

Fabric jar decompilation:
image

Common jar decompilation (mojmap names):
image

from smartbrainlib.

Jamalam360 avatar Jamalam360 commented on August 16, 2024

From a simple diff command on the extracted jars, it seems the Fabric and Common jars are the same directory and file wise, apart from the mappings. Maybe Fabric users only need to depend on the Fabric jar, not the common one as well? Documentation outdated?

from smartbrainlib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.