Comments (5)
Yes, adding HeapFree(g_hHeap, 0, g_hooks.pItems); before HeapDestroy in MH_Uninitialize() fixed leak.
from minhook.
PS: This is critical level bug IMHO, with many hooks leak can be really big. You should fix this ASAP.
from minhook.
Hi @Tapcio, thank you for your kindness!
I'm going to fix it soon as you just mentioned.
from minhook.
I committed the fix.
I'm going to do some tests and release the next version. Thanks!
from minhook.
According to the VLD forum it is a false positive, and you can use VLD_OPT_SKIP_HEAPFREE_LEAKS
option to avoid it.
However, I won't revert the commit 0cf8f96 because calling HeapFree
does nothing bad.
from minhook.
Related Issues (20)
- How Do I Fix HOT 1
- Freezing all threads is unsafe & slow
- Wrong disassembling HOT 1
- Concerns with increasing: MAX_MEMORY_RANGE? (FindPrevFreeRegion and FindNextFreeRegion return NULL) HOT 8
- MinHook seems to be failing to read the instructions properly HOT 2
- Unable to hook undocumented function HOT 1
- Hooking function fails due to FindPrevFreeRegion and FindNextFreeRegion returning null HOT 3
- How use it by Qt? HOT 1
- make a release HOT 1
- how to hook File operations to return a new file size to user?
- Failed to hook D3D11CreateDeviceAndSwapChain HOT 1
- `__movsb` not defined when cross compiling with clang
- yo HOT 1
- Mid Function Hooking HOT 1
- error cmake vs
- Win9x (95/98/Me) Support? HOT 1
- CreateToolhelp32Snapshot call is very heavy HOT 2
- MinHook Library Inclusion Issue HOT 1
- Cant find Minhook.h HOT 2
- How can I use minhook in my project without vcpkg downloading (it's not working for me)? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from minhook.