$relations setting to create orWhereHas

[lukevmk]

$relations setting to create orWhereHas

[Tucker-Eric]

Hmm, I think I follow what you're saying but not quite sure. Is there a code sample you're able to reference?

[lukevmk]

Ofcourse! I hope this example clarifies my case enough.

So, one ModelFilter looks like this currently:

public function query($term)  
{
    return $this->whereLike('name', $term). 
        ->orWhereHas('project', function($query) use ($term) {
            $query->where('name', 'LIKE', '%' . $term . '%')
                ->orWhere('alias', 'LIKE', '%' . $term . '%');  
        });  
}

But the duplicate code is happening in the project ModelFilter:

public function query($term)
{
   return $this->whereLike('name', $term)
          ->whereLike('alias', $term, 'or');
}

In this case I cannot use the $relations array from the ModelFilter because that wil build an whereHas. I am looking for an orWhereHas.

[Tucker-Eric]

That's an interesting issue. You are able to call other model filters from the parent. Does something like the following work to DRY it up a bit?

public function query($term)  
{
    return $this->whereLike('name', $term). 
        ->orWhereHas('project', function($query) use ($term) {
            $query->filter(['query' => $term]);
        });  
}

Or you could even pass all input to the related filter:

public function query($term)  
{
    return $this->whereLike('name', $term). 
        ->orWhereHas('project', function($query) {
            $query->filter($this->input());
        });  
}

Then to DRY it up a bit more with more than just one relation, something like the following could help?

public function query($term)  
{    
    $queryRelations = ['project', /* other relations*/]; 
    $query = $this->whereLike('name', $term);
    
    foreach ($queryRelations as $relation) {
        $query->orWhereHas($relation, function($query) {
            $query->filter($this->input());
        });
    }        
}

[lukevmk]

wauw, that's pretty smart! Thank you so much for your help!