Giter Site home page Giter Site logo

isPresentObjectForKey about tmcache HOT 5 OPEN

tumblrarchive avatar tumblrarchive commented on August 23, 2024
isPresentObjectForKey

from tmcache.

Comments (5)

Broich avatar Broich commented on August 23, 2024

+1

from tmcache.

jstn avatar jstn commented on August 23, 2024

EDIT: never mind, see below.

objectForKey: is functionally equivalent, treat any non-nil return value as "object present". In the end it's just an ordinary NSDictionary lookup (there's no difference between accessing an object and seeing if it exists).

http://stackoverflow.com/questions/2784648/how-to-check-if-an-nsdictionary-or-nsmutabledictionary-contains-a-key

https://github.com/tumblr/TMCache/blob/master/TMCache/TMCache.m#L67

from tmcache.

guptakshi16 avatar guptakshi16 commented on August 23, 2024

I do not agree on the above. Currently objectForKey returns the object also. The object may be in the file system which means an expensive disk read and unarchive just for the presence check.

Imagine a use case where we want to sync a local TMCache with a remote cache on the server.
Server publishes the current list of files. Client code iterates over the list sent by server and updates based on the server list. In this scenario a presence check is required for all files.

from tmcache.

jstn avatar jstn commented on August 23, 2024

@guptakshi16 you're totally right and I agree, thank you. It should be its own method, and TMDiskCache for its part should just check the presence of the file on disk.

Until that's added I think you could use TMDiskCache::fileURLForKey:block: and pass a block that manually checks for the file with NSURL::checkResourceIsReachableAndReturnError: followed immediately by a call to TMMemoryCache::objectForKey:block:

from tmcache.

irace avatar irace commented on August 23, 2024

This pull request might add the functionality that @guptakshi16 is asking for: #29

from tmcache.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.