VS2013 Issues

[tunabrain]

VS2013 Issues

[tunabrain]

I see, so there's multiple issues here. My current machine does not support AVX, so the MSVC AVX compilation did not get tested. Sorry!

MSVC seems to have problems with stack alignment in general. In particular, it can't align value parameters, so the only way to pass SIMD types in MSVC is by reference. For AVX it looks like this would need some modifications to embree, although I'm not sure I understand the performance implications of changing that parameter to pass by reference.

It's interesting that MSVC is unable to find fmaintrin.h. Is this not a standard header?

The last issue is a bit irritating, since MSVC implements __declspec(align()), but not alignas.

A longer-term fix needs a bit more investigation, but for now I think it is best to just disable AVX when compiling with MSVC. At least on gcc, the performance increase with AVX is barely noticeable anyway, and I am not taking advantage of embree's packet raytracing either.

[tunabrain]

I modified the CMake project to disable AVX on MSVC. Let me know if that fixes it for you.

[ddiakopoulos]

Great! Will give it another spin this afternoon.

[warmist]

Disabling AVX in cmake helped in my case. Strangely it did not happen automatically.

[tunabrain]

To fix #6, AVX is now disabled by default. That should take care of this issue as well.