How will this handle google analytics code?

[turbolinks]

How will this handle google analytics code?

[dhh]

pjax has a special, custom GA hook for this. I'm not overly keen on adding that to the main bundle.

On Sep 27, 2012, at 9:18 AM, David Estes wrote:

Just a thought, how does google analytics behave to this? Does the analytics snippet need changed in order to work?

Or do we handle this another way?

—
Reply to this email directly or view it on GitHub.

David Heinemeier Hansson

[halfdan]

The same question applies to other analytics tools like Piwik. Is there any way to hookup a function callback that gets called on page:change?

[dhh]

You can just listen for that event and document.addEventListener('page:change', function() {}).

On Sep 27, 2012, at 2:24 PM, Fabian Becker wrote:

The same question applies to other analytics tools like Piwik. Is there any way to hookup a function callback that gets called on page:change?

—
Reply to this email directly or view it on GitHub.

David Heinemeier Hansson

[davydotcom]

@dhh, hate to sound dumb but can we not fire a dom:loaded event on page:change so we can just monitor document.ready ?

[dhh]

I'm not actually sure that dom:loaded is even going fire the jquery document.ready, but yes, I actually do think it's worth considering. Originally we talked about not being sure what compatibility issues this might cause, but I think we should examine the case.

On Sep 27, 2012, at 2:50 PM, David Estes wrote:

@dhh, hate to sound dumb but can we not fire a dom:loaded event on page:change so we can just monitor document.ready ?

—
Reply to this email directly or view it on GitHub.

David Heinemeier Hansson

[davydotcom]

we only have to consider the browsers that support pushState which makes it a little easier to deal with.

[davydotcom]

Isnt really an issue with the gem per-say ...removing

[steverandy]

Why not do this instead?

$ -> $(document).trigger 'page:change'