Some inline script tags not being evaluated

[turbolinks]

Some inline script tags not being evaluated

[davydotcom]

I Know inline js shouldn't even be in there but we should support inline js execution if we can.

[davydotcom]

No js in your response body will operate at all.

This requires keeping everything out of the view including an init function call.

This is due to the use of DOMParser. it appears DOMParser will not evaluate javascript. document.write, however, will evaluate js to a point.

[davydotcom]

Heck, I might jus consider this a feature ! :)

[danbt79]

My inner arsehole tends to agree with you! This should be given thought though - is Rails' stance to simply not recommend doing this, or to prevent it working at all?

[davydotcom]

Right its also a potential issue that inline js using document references will have the wrong doc reference until after the content is replaced into the main document. A potential option is to scan for script tags after replace and evaluate them.

On Oct 1, 2012, at 12:21 PM, Daniel Beattie [email protected] wrote:

My inner arsehole tends to agree with you! This be given thought though - is Rails' stance to simply not recommend doing this, or to prevent it working at all?

—
Reply to this email directly or view it on GitHub.

[danbt79]

That sounds potentially brittle to me - I'd leave that up to caveat empor and making the developer aware of how this works. If you're using .js in this way and relying on document references like that, there should be some pain! I think we should just make sure .js can actually execute, and leave implementation details up to the .js author, rather than hacking a solution upstream on this library.

[davydotcom]

I got it to work by modifying changePage to get all script elements. I have not made a pull request yet, as i know @dhh is doing a major refactor. But this may be useful... document also gets the proper reference because they are not evaluated until after the fact.

changePage = (title, body) ->
  document.title = title
  document.documentElement.replaceChild body, document.body
  scripts = document.body.getElementsByTagName 'script'
  eval(script.innerHTML) for script in scripts
  currentState = historyState
  triggerEvent 'page:change'

[davydotcom]

Fixed